public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Nigel van Keulen <nigel2392@gmail.com>
To: pmg-devel@lists.proxmox.com
Cc: Nigel van Keulen <nigel2392@gmail.com>
Subject: [pmg-devel] SPAM: [PATCH pmg-api 1/1] fix: 2971, to DKIM signing for OOO messages by using postmaster@<domain> as a sender if it is not present.
Date: Sat, 18 May 2024 16:58:55 +0200	[thread overview]
Message-ID: <20240518145855.670-2-nigel2392@gmail.com> (raw)
In-Reply-To: <20240518145855.670-1-nigel2392@gmail.com>

---
 src/PMG/RuleDB/Accept.pm | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/src/PMG/RuleDB/Accept.pm b/src/PMG/RuleDB/Accept.pm
index e3e39a7..8a6261f 100644
--- a/src/PMG/RuleDB/Accept.pm
+++ b/src/PMG/RuleDB/Accept.pm
@@ -101,8 +101,16 @@ sub execute {
 	PMG::Utils::remove_marks($entity);
 
 	if ($dkim->{sign}) {
+
+		my $mailSender = $msginfo->{sender};
+		if ($mailSender eq '') {
+			my $mailDomain = $msginfo->{domain};
+			$mailSender = "postmaster\@$mailDomain";
+			syslog('info', "%s: No sender found, using default sender: %s", $queue->{logid}, $mailSender);
+		}
+
 	    eval {
-		$entity = PMG::DKIMSign::sign_entity($entity, $dkim, $msginfo->{sender});
+		$entity = PMG::DKIMSign::sign_entity($entity, $dkim, $mailSender);
 	    };
 	    if ($@) {
 		syslog('warning',
-- 
2.43.0.windows.1


_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel


  reply	other threads:[~2024-05-22  7:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-18 14:58 [pmg-devel] SPAM: [PATCH pmg-api 0/1] *** Fix OOO e-mail's DKIM signatures *** Nigel van Keulen
2024-05-18 14:58 ` Nigel van Keulen [this message]
2024-05-22 12:05   ` [pmg-devel] SPAM: [PATCH pmg-api 1/1] fix: 2971, to DKIM signing for OOO messages by using postmaster@<domain> as a sender if it is not present Shannon Sterz
     [not found]     ` <CAD-rDhfxenLiYSiTVQjWCdc=G0ooKirUQVR6GJDFJmhU_jESug@mail.gmail.com>
     [not found]       ` <D1H4170KM7OL.7HNFYXHGMV1H@proxmox.com>
2024-05-23 15:06         ` Shannon Sterz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240518145855.670-2-nigel2392@gmail.com \
    --to=nigel2392@gmail.com \
    --cc=pmg-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal