From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: Stefan Sterz <s.sterz@proxmox.com>
Cc: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] applied: [PATCH pmg-gui] ui: trim whitespaces when adding a subscription key
Date: Fri, 1 Mar 2024 11:41:48 +0100 [thread overview]
Message-ID: <20240301114148.26264573@rosa.proxmox.com> (raw)
In-Reply-To: <20240301095430.64525-1-s.sterz@proxmox.com>
Thanks for the patch! applied after testing it in a fresh pmg-8.1 container
On Fri, 1 Mar 2024 10:54:30 +0100
Stefan Sterz <s.sterz@proxmox.com> wrote:
> users that add the correct subscription key just get unnecessarily
> confused with a "value does not match the regex pattern" error if
> they accidentally have a stray whitespace at the end or beginning
> otherwise.
>
> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
> ---
> js/Subscription.js | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/js/Subscription.js b/js/Subscription.js
> index 2293cdb..6d7380c 100644
> --- a/js/Subscription.js
> +++ b/js/Subscription.js
> @@ -8,7 +8,8 @@ Ext.define('PMG.SubscriptionKeyEdit', {
> onlineHelp: 'getting_help',
>
> items: {
> - xtype: 'textfield',
> + xtype: 'proxmoxtextfield',
> + trimValue: true,
> name: 'key',
> value: '',
> fieldLabel: gettext('Subscription Key'),
prev parent reply other threads:[~2024-03-01 10:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 9:54 [pmg-devel] " Stefan Sterz
2024-03-01 10:41 ` Stoiko Ivanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240301114148.26264573@rosa.proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox