* [pmg-devel] [PATCH pmg-gui] objects: add separator between match field selector and description
@ 2024-02-27 8:53 Dominik Csapak
2024-02-27 14:04 ` [pmg-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2024-02-27 8:53 UTC (permalink / raw)
To: pmg-devel
to make it easier to see they are separate
for that we have to make the top level docked item a 'toolbar'
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
js/ObjectGroup.js | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/js/ObjectGroup.js b/js/ObjectGroup.js
index 8c72dd2..4fc74ed 100644
--- a/js/ObjectGroup.js
+++ b/js/ObjectGroup.js
@@ -40,6 +40,7 @@ Ext.define('PMG.ObjectGroup', {
if (me.ogdata === undefined) {
me.down('#oginfo').update(me.emptyText);
+ me.down('#separator').setHidden(true);
me.down('#modeBox').setHidden(true);
me.down('#whatWarning').setHidden(true);
} else {
@@ -49,6 +50,7 @@ Ext.define('PMG.ObjectGroup', {
me.down('#oginfo').update(html);
me.down('#ogdata').setHidden(false);
+ me.down('#separator').setHidden(false);
let modeSelector = me.down('#modeSelector');
modeSelector.suspendEvents();
me.down('#modeSelector').setValue(mode);
@@ -228,9 +230,13 @@ Ext.define('PMG.ObjectGroup', {
me.dockedItems.push({
dock: 'top',
border: 1,
- layout: 'hbox',
+ layout: {
+ type: 'hbox',
+ align: 'stretch',
+ },
hidden: !!me.hideGroupInfo,
itemId: 'ogdata',
+ xtype: 'toolbar',
items: [
{
xtype: 'container',
@@ -274,6 +280,11 @@ Ext.define('PMG.ObjectGroup', {
},
],
},
+ {
+ xtype: 'tbseparator',
+ itemId: 'separator',
+ hidden: true,
+ },
{
xtype: 'component',
flex: 1,
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pmg-devel] applied: [PATCH pmg-gui] objects: add separator between match field selector and description
2024-02-27 8:53 [pmg-devel] [PATCH pmg-gui] objects: add separator between match field selector and description Dominik Csapak
@ 2024-02-27 14:04 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2024-02-27 14:04 UTC (permalink / raw)
To: Dominik Csapak, pmg-devel
Am 27/02/2024 um 09:53 schrieb Dominik Csapak:
> to make it easier to see they are separate
> for that we have to make the top level docked item a 'toolbar'
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> js/ObjectGroup.js | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-27 14:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-27 8:53 [pmg-devel] [PATCH pmg-gui] objects: add separator between match field selector and description Dominik Csapak
2024-02-27 14:04 ` [pmg-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox