From: Dominik Csapak <d.csapak@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] [PATCH pmg-gui] objects: add separator between match field selector and description
Date: Tue, 27 Feb 2024 09:53:15 +0100 [thread overview]
Message-ID: <20240227085315.1009635-1-d.csapak@proxmox.com> (raw)
to make it easier to see they are separate
for that we have to make the top level docked item a 'toolbar'
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
js/ObjectGroup.js | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/js/ObjectGroup.js b/js/ObjectGroup.js
index 8c72dd2..4fc74ed 100644
--- a/js/ObjectGroup.js
+++ b/js/ObjectGroup.js
@@ -40,6 +40,7 @@ Ext.define('PMG.ObjectGroup', {
if (me.ogdata === undefined) {
me.down('#oginfo').update(me.emptyText);
+ me.down('#separator').setHidden(true);
me.down('#modeBox').setHidden(true);
me.down('#whatWarning').setHidden(true);
} else {
@@ -49,6 +50,7 @@ Ext.define('PMG.ObjectGroup', {
me.down('#oginfo').update(html);
me.down('#ogdata').setHidden(false);
+ me.down('#separator').setHidden(false);
let modeSelector = me.down('#modeSelector');
modeSelector.suspendEvents();
me.down('#modeSelector').setValue(mode);
@@ -228,9 +230,13 @@ Ext.define('PMG.ObjectGroup', {
me.dockedItems.push({
dock: 'top',
border: 1,
- layout: 'hbox',
+ layout: {
+ type: 'hbox',
+ align: 'stretch',
+ },
hidden: !!me.hideGroupInfo,
itemId: 'ogdata',
+ xtype: 'toolbar',
items: [
{
xtype: 'container',
@@ -274,6 +280,11 @@ Ext.define('PMG.ObjectGroup', {
},
],
},
+ {
+ xtype: 'tbseparator',
+ itemId: 'separator',
+ hidden: true,
+ },
{
xtype: 'component',
flex: 1,
--
2.30.2
next reply other threads:[~2024-02-27 8:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 8:53 Dominik Csapak [this message]
2024-02-27 14:04 ` [pmg-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240227085315.1009635-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox