* [pmg-devel] [PATCH pmg-gui] fix #2971: DKIM: add gui setting to use From header when signing
@ 2024-02-23 12:52 Maximiliano Sandoval
2024-02-26 16:35 ` [pmg-devel] applied: " Stoiko Ivanov
0 siblings, 1 reply; 2+ messages in thread
From: Maximiliano Sandoval @ 2024-02-23 12:52 UTC (permalink / raw)
To: pmg-devel
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
js/DKIMSettings.js | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/js/DKIMSettings.js b/js/DKIMSettings.js
index 9cebfeb..21f572d 100644
--- a/js/DKIMSettings.js
+++ b/js/DKIMSettings.js
@@ -120,6 +120,11 @@ Ext.define('PMG.DKIMSettings', {
monStoreErrors: true,
+ dkimdomainTextHash: {
+ envelope: gettext('Envelope'),
+ header: gettext('Header'),
+ },
+
initComponent: function() {
var me = this;
@@ -183,6 +188,17 @@ Ext.define('PMG.DKIMSettings', {
},
};
+ var render_dkimdomain = function(value) {
+ return me.dkimdomainTextHash[value] || value;
+ };
+ me.add_combobox_row('dkim-use-domain', gettext('Get Signing Domain From'), {
+ renderer: render_dkimdomain,
+ defaultValue: 'envelope',
+ comboItems: [
+ ['envelope', render_dkimdomain('envelope')],
+ ['header', render_dkimdomain('header')]],
+ });
+
me.add_boolean_row('dkim_sign_all_mail', gettext('Sign all Outgoing Mail'));
var baseurl = '/config/admin';
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pmg-devel] applied: [PATCH pmg-gui] fix #2971: DKIM: add gui setting to use From header when signing
2024-02-23 12:52 [pmg-devel] [PATCH pmg-gui] fix #2971: DKIM: add gui setting to use From header when signing Maximiliano Sandoval
@ 2024-02-26 16:35 ` Stoiko Ivanov
0 siblings, 0 replies; 2+ messages in thread
From: Stoiko Ivanov @ 2024-02-26 16:35 UTC (permalink / raw)
To: Maximiliano Sandoval; +Cc: pmg-devel
applied the patch after testing it shortly in my setup - Thanks!
On Fri, 23 Feb 2024 13:52:00 +0100
Maximiliano Sandoval <m.sandoval@proxmox.com> wrote:
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> js/DKIMSettings.js | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/js/DKIMSettings.js b/js/DKIMSettings.js
> index 9cebfeb..21f572d 100644
> --- a/js/DKIMSettings.js
> +++ b/js/DKIMSettings.js
> @@ -120,6 +120,11 @@ Ext.define('PMG.DKIMSettings', {
>
> monStoreErrors: true,
>
> + dkimdomainTextHash: {
> + envelope: gettext('Envelope'),
> + header: gettext('Header'),
> + },
> +
> initComponent: function() {
> var me = this;
>
> @@ -183,6 +188,17 @@ Ext.define('PMG.DKIMSettings', {
> },
> };
>
> + var render_dkimdomain = function(value) {
> + return me.dkimdomainTextHash[value] || value;
> + };
> + me.add_combobox_row('dkim-use-domain', gettext('Get Signing Domain From'), {
> + renderer: render_dkimdomain,
> + defaultValue: 'envelope',
> + comboItems: [
> + ['envelope', render_dkimdomain('envelope')],
> + ['header', render_dkimdomain('header')]],
> + });
> +
> me.add_boolean_row('dkim_sign_all_mail', gettext('Sign all Outgoing Mail'));
>
> var baseurl = '/config/admin';
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-26 16:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-23 12:52 [pmg-devel] [PATCH pmg-gui] fix #2971: DKIM: add gui setting to use From header when signing Maximiliano Sandoval
2024-02-26 16:35 ` [pmg-devel] applied: " Stoiko Ivanov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox