From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: Maximiliano Sandoval <m.sandoval@proxmox.com>
Cc: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] applied: [PATCH pmg-gui] fix #2971: DKIM: add gui setting to use From header when signing
Date: Mon, 26 Feb 2024 17:35:53 +0100 [thread overview]
Message-ID: <20240226173553.34e34dca@rosa.proxmox.com> (raw)
In-Reply-To: <20240223125200.429723-1-m.sandoval@proxmox.com>
applied the patch after testing it shortly in my setup - Thanks!
On Fri, 23 Feb 2024 13:52:00 +0100
Maximiliano Sandoval <m.sandoval@proxmox.com> wrote:
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> js/DKIMSettings.js | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/js/DKIMSettings.js b/js/DKIMSettings.js
> index 9cebfeb..21f572d 100644
> --- a/js/DKIMSettings.js
> +++ b/js/DKIMSettings.js
> @@ -120,6 +120,11 @@ Ext.define('PMG.DKIMSettings', {
>
> monStoreErrors: true,
>
> + dkimdomainTextHash: {
> + envelope: gettext('Envelope'),
> + header: gettext('Header'),
> + },
> +
> initComponent: function() {
> var me = this;
>
> @@ -183,6 +188,17 @@ Ext.define('PMG.DKIMSettings', {
> },
> };
>
> + var render_dkimdomain = function(value) {
> + return me.dkimdomainTextHash[value] || value;
> + };
> + me.add_combobox_row('dkim-use-domain', gettext('Get Signing Domain From'), {
> + renderer: render_dkimdomain,
> + defaultValue: 'envelope',
> + comboItems: [
> + ['envelope', render_dkimdomain('envelope')],
> + ['header', render_dkimdomain('header')]],
> + });
> +
> me.add_boolean_row('dkim_sign_all_mail', gettext('Sign all Outgoing Mail'));
>
> var baseurl = '/config/admin';
prev parent reply other threads:[~2024-02-26 16:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 12:52 [pmg-devel] " Maximiliano Sandoval
2024-02-26 16:35 ` Stoiko Ivanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240226173553.34e34dca@rosa.proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox