public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: Maximiliano Sandoval <m.sandoval@proxmox.com>
Cc: pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH] dkim: document dkim_use_domain
Date: Fri, 23 Feb 2024 18:17:22 +0100	[thread overview]
Message-ID: <20240223181722.662d5bf7@rosa.proxmox.com> (raw)
In-Reply-To: <20240219130036.445696-1-m.sandoval@proxmox.com>

Thanks for addressing this!

comment inline:
On Mon, 19 Feb 2024 14:00:36 +0100
Maximiliano Sandoval <m.sandoval@proxmox.com> wrote:

> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> Continuation of https://lists.proxmox.com/pipermail/pmg-devel/2024-February/002714.html.
> 
>  pmgconfig.adoc | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/pmgconfig.adoc b/pmgconfig.adoc
> index bf3887e..0acb8e9 100644
> --- a/pmgconfig.adoc
> +++ b/pmgconfig.adoc
> @@ -585,6 +585,13 @@ Controls whether all outbound mail should get signed or only mails from domains
>  listed in `/etc/pmg/dkim/domains`, if it exists and `/etc/pmg/domains`
>  otherwise.
>  
> +Select Signing Domain::
> +
> +Determines whether to DKIM sign emails using the domain found in the envelope
> +from or the from header in the body of the email. Some emails do not set a
here I'd probably add a reference to RFC5321 and RFC5322 respectively 
> +return path and it is desirable to sign them using the domain found in the from
I personally would rather phrase that as:
`Some emails are sent with an empty envelope sender` instead of not
setting a return path (the Return-Path header is usually set by some MTA
on the transport-path of the mail.
> +header.
> +
Additionally - I'd mention that DMARC (with reference to the RFC+section)
needs the header-from as domain in certain situations.


>  These settings are saved to the 'admin' subsection in `/etc/pmg/pmg.conf`,
>  using the following configuration keys:
>  





      reply	other threads:[~2024-02-23 17:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-19 13:00 Maximiliano Sandoval
2024-02-23 17:17 ` Stoiko Ivanov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240223181722.662d5bf7@rosa.proxmox.com \
    --to=s.ivanov@proxmox.com \
    --cc=m.sandoval@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal