public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>
Cc: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] applied: [PATCH pmg-api] pmgdb: add object type text to output
Date: Thu, 22 Feb 2024 21:56:29 +0100	[thread overview]
Message-ID: <20240222215629.0511472f@rosa.proxmox.com> (raw)
In-Reply-To: <20240209133700.2912110-1-d.csapak@proxmox.com>

thanks for the patch!


On Fri,  9 Feb 2024 14:37:00 +0100
Dominik Csapak <d.csapak@proxmox.com> wrote:

> this makes it easier to differntiate between e.g.
> a domain entry 'foo.com'
> and a regex entry 'foo.com'
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  src/PMG/CLI/pmgdb.pm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/PMG/CLI/pmgdb.pm b/src/PMG/CLI/pmgdb.pm
> index 8368af8..6310112 100644
> --- a/src/PMG/CLI/pmgdb.pm
> +++ b/src/PMG/CLI/pmgdb.pm
> @@ -32,8 +32,9 @@ sub print_objects {
>      my $objects = $ruledb->load_group_objects ($og->{id});
>  
>      foreach my $obj (@$objects) {
> +	my $type_text = $obj->otype_text();
>  	my $desc = encode('UTF-8', $obj->short_desc());
> -	print "    OBJECT $obj->{id}: $desc\n";
> +	print "    OBJECT $type_text $obj->{id}: $desc\n";
>      }
>  }
>  





      reply	other threads:[~2024-02-22 20:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-09 13:37 [pmg-devel] " Dominik Csapak
2024-02-22 20:56 ` Stoiko Ivanov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240222215629.0511472f@rosa.proxmox.com \
    --to=s.ivanov@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal