From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] [PATCH pmg-api] quarantine: userlists: sort result
Date: Thu, 22 Feb 2024 22:07:30 +0100 [thread overview]
Message-ID: <20240222210730.362840-1-s.ivanov@proxmox.com> (raw)
probably just cosmetic - but I noticed it while testing the patch that
fixes the sync of an empty userlist.
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
src/PMG/Quarantine.pm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/PMG/Quarantine.pm b/src/PMG/Quarantine.pm
index e19e96f..d06a88d 100644
--- a/src/PMG/Quarantine.pm
+++ b/src/PMG/Quarantine.pm
@@ -59,8 +59,8 @@ sub add_to_blackwhite {
}
}
- my $wlist = $dbh->quote(encode('UTF-8', join (',', keys %{$list->{WL}})) || '');
- my $blist = $dbh->quote(encode('UTF-8', join (',', keys %{$list->{BL}})) || '');
+ my $wlist = $dbh->quote(encode('UTF-8', join (',', sort keys %{$list->{WL}})) || '');
+ my $blist = $dbh->quote(encode('UTF-8', join (',', sort keys %{$list->{BL}})) || '');
if (!$delete) {
my $maxlen = 200000;
@@ -81,7 +81,7 @@ sub add_to_blackwhite {
$dbh->do($queries);
}
- my $values = [ keys %{$list->{$name}} ];
+ my $values = [ sort keys %{$list->{$name}} ];
return $values;
}
--
2.39.2
next reply other threads:[~2024-02-22 21:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 21:07 Stoiko Ivanov [this message]
2024-02-23 16:50 ` [pmg-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240222210730.362840-1-s.ivanov@proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox