public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] [PATCH pmg-gui] objects: use font-weight for bold text
Date: Thu, 22 Feb 2024 15:29:41 +0100	[thread overview]
Message-ID: <20240222142941.2912401-1-d.csapak@proxmox.com> (raw)

mdn[0] recommends using `font-weight: bold;` for making the text actually bold
While it has the same effect often, it depends on the font and browser
if the font is rendered bold in a <b> tag.

0: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/b

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 js/ObjectGroup.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/js/ObjectGroup.js b/js/ObjectGroup.js
index d72d47c..8c72dd2 100644
--- a/js/ObjectGroup.js
+++ b/js/ObjectGroup.js
@@ -43,7 +43,7 @@ Ext.define('PMG.ObjectGroup', {
 	    me.down('#modeBox').setHidden(true);
 	    me.down('#whatWarning').setHidden(true);
 	} else {
-	    let html = '<b>' + Ext.String.htmlEncode(me.ogdata.name) + '</b>';
+	    let html = '<b style="font-weight: bold;">' + Ext.String.htmlEncode(me.ogdata.name) + '</b>';
 	    html += "<br><br>";
 	    html += Ext.String.htmlEncode(Ext.String.trim(me.ogdata.info));
 
@@ -245,7 +245,7 @@ Ext.define('PMG.ObjectGroup', {
 		    items: [
 			{
 			    xtype: 'box',
-			    html: `<b>${gettext("Match if")}</b>`,
+			    html: `<b style="font-weight: bold;">${gettext("Match if")}</b>`,
 			},
 			{
 			    xtype: 'pmgMatchModeSelector',
-- 
2.30.2





             reply	other threads:[~2024-02-22 14:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-22 14:29 Dominik Csapak [this message]
2024-02-22 14:51 ` [pmg-devel] applied: " Thomas Lamprecht
2024-02-22 16:36   ` Stefan Sterz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240222142941.2912401-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal