public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>
Cc: pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH pmg-gui v3 0/3] implement and combination and inversion of groups and objects
Date: Thu, 22 Feb 2024 14:19:22 +0100	[thread overview]
Message-ID: <20240222141922.3b143b6c@rosa.proxmox.com> (raw)
In-Reply-To: <20240222091420.2732402-1-d.csapak@proxmox.com>

FWIW: applied it locally, gave it a spin, and verified that the
deletion-bug is gone! 

Thanks for the fast iteration!

On Thu, 22 Feb 2024 10:14:17 +0100
Dominik Csapak <d.csapak@proxmox.com> wrote:

> since the rest got applied, the new version of the ui part
> 
> note that patch 3 is intended to be an alternative way of handling the
> update of the object list when the mode changes. so if desired can be
> squashed in with patch 2 (needs then the commit message adapted)
> 
> alternatively it can simply be left out
> 
> changes from v2:
> * left out applied patches
> * added padding in the RuleInfo panel for type groupings
> * fixed a bug with deletion
> * incoroporated thomas' suggestions
> 
> changes from v1:
> * rebase on master
> * include new tables in cluster sync + backup
> * incorporate stoikos feedback
> * improved commit messages
> more details in the relevant patches
> 
> changes from rfc:
> * added docs + gui
> * some minor bugfixes
> * fixed the api (forgot to add the info to the GET calls in rfc)
> * changed output for `pmgdb dump` so we get that info in the pmgreport too
> 
> Dominik Csapak (3):
>   rules: use tree panel instead of grouping feature of the grid
>   rules/objects: add mode selector dropdown
>   objects: don't reload on match mode change
> 
>  css/ext6-pmg.css               |  11 ++++
>  js/Makefile                    |   1 +
>  js/ObjectGroup.js              |  72 ++++++++++++++++++++++-
>  js/ObjectGroupConfiguration.js |   7 +++
>  js/RuleInfo.js                 | 102 ++++++++++++++++++++++++++-------
>  js/form/MatchModeSelector.js   |  11 ++++
>  6 files changed, 181 insertions(+), 23 deletions(-)
>  create mode 100644 js/form/MatchModeSelector.js
> 





  parent reply	other threads:[~2024-02-22 13:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-22  9:14 Dominik Csapak
2024-02-22  9:14 ` [pmg-devel] [PATCH pmg-gui v3 1/3] rules: use tree panel instead of grouping feature of the grid Dominik Csapak
2024-02-22  9:14 ` [pmg-devel] [PATCH pmg-gui v3 2/3] rules/objects: add mode selector dropdown Dominik Csapak
2024-02-22  9:14 ` [pmg-devel] [PATCH pmg-gui v3 3/3] objects: don't reload on match mode change Dominik Csapak
2024-02-22 13:19 ` Stoiko Ivanov [this message]
2024-02-22 13:26   ` [pmg-devel] [PATCH pmg-gui v3 0/3] implement and combination and inversion of groups and objects Thomas Lamprecht
2024-02-22 13:51     ` Stoiko Ivanov
2024-02-22 14:24 ` [pmg-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240222141922.3b143b6c@rosa.proxmox.com \
    --to=s.ivanov@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal