public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>
Cc: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] applied: [PATCH pmg-api] api: relaod ruledb on updating objecgroups
Date: Thu, 22 Feb 2024 14:18:42 +0100	[thread overview]
Message-ID: <20240222141842.7946a7ae@rosa.proxmox.com> (raw)
In-Reply-To: <20240222100457.3462419-1-d.csapak@proxmox.com>

Thanks for finding and fixing this!
applied the patch, with the 2 typos in the subject line fixed up,
after testing it (watching the journal while sending mails before/after,
looking for 
`pmg-smtp-filter[333766]: reloading configuration Proxmox_ruledb` )


On Thu, 22 Feb 2024 11:04:57 +0100
Dominik Csapak <d.csapak@proxmox.com> wrote:

> previously they only contained metadata (name/comment) so for the
> rulesystem that was not relevant. Now with the attributes and/invert
> we want to reload the ruledb on update too.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  src/PMG/API2/ObjectGroupHelpers.pm | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/PMG/API2/ObjectGroupHelpers.pm b/src/PMG/API2/ObjectGroupHelpers.pm
> index 3060157..fabfa6a 100644
> --- a/src/PMG/API2/ObjectGroupHelpers.pm
> +++ b/src/PMG/API2/ObjectGroupHelpers.pm
> @@ -289,6 +289,8 @@ sub register_object_group_config_api {
>  
>  	    $rdb->save_group($og);
>  
> +	    PMG::DBTools::reload_ruledb();
> +
>  	    return undef;
>  	}});
>  }





      parent reply	other threads:[~2024-02-22 13:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-22 10:04 [pmg-devel] " Dominik Csapak
2024-02-22 10:06 ` Dominik Csapak
2024-02-22 13:18 ` Stoiko Ivanov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240222141842.7946a7ae@rosa.proxmox.com \
    --to=s.ivanov@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal