From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>
Cc: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] applied-partially: [PATCH pmg-api/docs/gui v2] implement and combination and inversion of groups and objects
Date: Wed, 21 Feb 2024 19:36:35 +0100 [thread overview]
Message-ID: <20240221193635.35430834@rosa.proxmox.com> (raw)
In-Reply-To: <20240221122439.1281024-1-d.csapak@proxmox.com>
huge thanks for the series and the quick iteration on my nits!
applied the api and docs patches, left the gui patches for now after a
talk with Thomas off-list.
On Wed, 21 Feb 2024 13:24:26 +0100
Dominik Csapak <d.csapak@proxmox.com> wrote:
> This series is the backend part of the and/inversion addition to the
> rule system.
>
> The gui change is rather simple, just one additional drop down for
> groups + one for each type in each rule.
>
> changes from v1:
> * rebase on master
> * include new tables in cluster sync + backup
> * incorporate stoikos feedback
> * improved commit messages
> more details in the relevant patches
>
> changes from rfc:
> * added docs + gui
> * some minor bugfixes
> * fixed the api (forgot to add the info to the GET calls in rfc)
> * changed output for `pmgdb dump` so we get that info in the pmgreport too
>
> pmg-api:
>
> Dominik Csapak (10):
> RuleCache: reorganize how we gather marks and spaminfo
> api: refactor rule parameters
> add objectgroup attributes and/invert
> add rule attributes and/invert (for each relevant type)
> RuleCache: load rule/objectgroup attributes from database
> RuleCache: implement and/invert for when/from/to
> MailQueue: return maximum AID
> ModGroup: add possibility to explode to all targets
> RuleCache: implement and/invert for what matches
> pmgdb: extend dump output to include add/invert
>
> src/PMG/API2/ObjectGroupHelpers.pm | 51 +++++-
> src/PMG/API2/RuleDB.pm | 23 +--
> src/PMG/API2/Rules.pm | 94 ++++++++--
> src/PMG/Backup.pm | 2 +
> src/PMG/CLI/pmgdb.pm | 38 +++-
> src/PMG/Cluster.pm | 4 +
> src/PMG/DBTools.pm | 32 ++++
> src/PMG/MailQueue.pm | 4 +-
> src/PMG/ModGroup.pm | 17 ++
> src/PMG/RuleCache.pm | 274 +++++++++++++++++++++++-----
> src/PMG/RuleDB.pm | 278 +++++++++++++++++++++++------
> src/PMG/RuleDB/Remove.pm | 28 ++-
> src/PMG/Utils.pm | 2 +
> src/bin/pmg-smtp-filter | 23 +--
> 14 files changed, 701 insertions(+), 169 deletions(-)
>
> pmg-docs:
>
> Dominik Csapak (1):
> rule system: explain new and mode and invert flag
>
> pmg-mail-filter.adoc | 40 +++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 39 insertions(+), 1 deletion(-)
>
> pmg-gui:
>
> Dominik Csapak (2):
> rules: use tree panel instead of grouping feature of the grid
> rules/objects: add mode selector dropdown
>
> css/ext6-pmg.css | 7 +++
> js/Makefile | 1 +
> js/ObjectGroup.js | 64 +++++++++++++++++++-
> js/ObjectGroupConfiguration.js | 4 ++
> js/RuleInfo.js | 103 ++++++++++++++++++++++++++-------
> js/form/ModeSelector.js | 11 ++++
> 6 files changed, 167 insertions(+), 23 deletions(-)
> create mode 100644 js/form/ModeSelector.js
>
prev parent reply other threads:[~2024-02-21 18:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 12:24 [pmg-devel] " Dominik Csapak
2024-02-21 12:24 ` [pmg-devel] [PATCH pmg-api v2 01/10] RuleCache: reorganize how we gather marks and spaminfo Dominik Csapak
2024-02-21 12:24 ` [pmg-devel] [PATCH pmg-api v2 02/10] api: refactor rule parameters Dominik Csapak
2024-02-21 12:24 ` [pmg-devel] [PATCH pmg-api v2 03/10] add objectgroup attributes and/invert Dominik Csapak
2024-02-21 12:24 ` [pmg-devel] [PATCH pmg-api v2 04/10] add rule attributes and/invert (for each relevant type) Dominik Csapak
2024-02-22 6:46 ` Thomas Lamprecht
2024-02-22 7:34 ` Dominik Csapak
2024-02-22 7:38 ` Thomas Lamprecht
2024-02-21 12:24 ` [pmg-devel] [PATCH pmg-api v2 05/10] RuleCache: load rule/objectgroup attributes from database Dominik Csapak
2024-02-21 12:24 ` [pmg-devel] [PATCH pmg-api v2 06/10] RuleCache: implement and/invert for when/from/to Dominik Csapak
2024-02-21 12:24 ` [pmg-devel] [PATCH pmg-api v2 07/10] MailQueue: return maximum AID Dominik Csapak
2024-02-21 12:24 ` [pmg-devel] [PATCH pmg-api v2 08/10] ModGroup: add possibility to explode to all targets Dominik Csapak
2024-02-21 12:24 ` [pmg-devel] [PATCH pmg-api v2 09/10] RuleCache: implement and/invert for what matches Dominik Csapak
2024-02-21 12:24 ` [pmg-devel] [PATCH pmg-api v2 10/10] pmgdb: extend dump output to include add/invert Dominik Csapak
2024-02-21 12:24 ` [pmg-devel] [PATCH pmg-docs v2 1/1] rule system: explain new and mode and invert flag Dominik Csapak
2024-02-21 12:24 ` [pmg-devel] [PATCH pmg-gui v2 1/2] rules: use tree panel instead of grouping feature of the grid Dominik Csapak
2024-02-21 17:42 ` Thomas Lamprecht
2024-02-21 12:24 ` [pmg-devel] [PATCH pmg-gui v2 2/2] rules/objects: add mode selector dropdown Dominik Csapak
2024-02-21 18:31 ` Thomas Lamprecht
2024-02-21 18:36 ` Stoiko Ivanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240221193635.35430834@rosa.proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox