From: LoveSy <shana@zju.edu.cn>
To: pmg-devel@lists.proxmox.com
Cc: YU Jincheng <shana@zju.edu.cn>
Subject: [pmg-devel] [PATCH acme 1/1] Fix EBA MAC key decoding
Date: Wed, 17 Jan 2024 01:43:28 +0800 [thread overview]
Message-ID: <20240116174328.75567-2-shana@zju.edu.cn> (raw)
In-Reply-To: <20240116174328.75567-1-shana@zju.edu.cn>
From: YU Jincheng <shana@zju.edu.cn>
Accroding to RFC 8555:
> The MAC key SHOULD be provided in base64url-encoded form...
However, currently we are only decoding the MAC key as base64.
This patch uses the correct function to decode the user provided
MAC key as base64url format.
Signed-off-by: YU Jincheng <shana@zju.edu.cn>
---
src/PVE/ACME.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/PVE/ACME.pm b/src/PVE/ACME.pm
index bf5410d..428cdda 100644
--- a/src/PVE/ACME.pm
+++ b/src/PVE/ACME.pm
@@ -7,7 +7,7 @@ use POSIX;
use Data::Dumper;
use Date::Parse;
-use MIME::Base64 qw(encode_base64url decode_base64);
+use MIME::Base64 qw(encode_base64url decode_base64url);
use File::Path qw(make_path);
use JSON;
use Digest::SHA qw(sha256 sha256_hex hmac_sha256);
@@ -365,7 +365,7 @@ sub new_account {
my %payload = ( contact => $info{contact} );
if (defined($info{eab})) {
- my $eab_hmac_key = decode_base64($info{eab}->{hmac_key});
+ my $eab_hmac_key = decode_base64url($info{eab}->{hmac_key});
$payload{externalAccountBinding} = external_account_binding_jws(
$info{eab}->{kid},
$eab_hmac_key,
--
2.39.3 (Apple Git-145)
next prev parent reply other threads:[~2024-01-16 17:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 17:43 [pmg-devel] [PATCH acme 0/1] " LoveSy
2024-01-16 17:43 ` LoveSy [this message]
2024-01-18 9:31 ` [pmg-devel] [PATCH acme 1/1] " Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240116174328.75567-2-shana@zju.edu.cn \
--to=shana@zju.edu.cn \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox