From: Dominik Csapak <d.csapak@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] [PATCH pmg-gui v2 1/2] disclaimer edit: add position comobobox
Date: Mon, 15 Jan 2024 12:12:40 +0100 [thread overview]
Message-ID: <20240115111242.2781994-4-d.csapak@proxmox.com> (raw)
In-Reply-To: <20240115111242.2781994-1-d.csapak@proxmox.com>
to enable setting the disclaimer position
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
changes from v1:
* change from checkbox to combobox, adapting to the backend changes
improving clarity
js/Utils.js | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/js/Utils.js b/js/Utils.js
index 7fa154e..974df1f 100644
--- a/js/Utils.js
+++ b/js/Utils.js
@@ -686,6 +686,17 @@ Ext.define('PMG.Utils', {
growMax: 250,
fieldLabel: gettext("Disclaimer"),
},
+ {
+ xtype: 'proxmoxKVComboBox',
+ name: 'position',
+ fieldLabel: gettext("Position"),
+ deleteEmpty: false,
+ value: 'end',
+ comboItems: [
+ ['end', gettext('End')],
+ ['start', gettext('Start')],
+ ],
+ },
],
},
},
--
2.30.2
next prev parent reply other threads:[~2024-01-15 11:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-15 11:12 [pmg-devel] [PATCH pmg-api/gui/docs v2] ruledb disclaimer improvements Dominik Csapak
2024-01-15 11:12 ` [pmg-devel] [PATCH pmg-api v2 1/2] fix #2606: ruledb disclaimer: add ability to set position Dominik Csapak
2024-01-15 11:12 ` [pmg-devel] [PATCH pmg-api v2 2/2] fix #2430: ruledb disclaimer: make separator configurable Dominik Csapak
2024-01-15 11:12 ` Dominik Csapak [this message]
2024-01-15 11:12 ` [pmg-devel] [PATCH pmg-gui v2 2/2] disclaimer edit: add 'add-separator' checkbox Dominik Csapak
2024-02-23 8:02 ` Thomas Lamprecht
2024-01-15 11:12 ` [pmg-devel] [PATCH pmg-docs v2 1/1] add disclaimer position/separator docs Dominik Csapak
2024-02-23 8:01 ` [pmg-devel] applied-series: [PATCH pmg-api/gui/docs v2] ruledb disclaimer improvements Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240115111242.2781994-4-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox