[pmg-devel] [PATCH pmg-gui 1/2] gui: Mark missing strings as translatable

[pmg-devel] [PATCH pmg-gui 1/2] gui: Mark missing strings as translatable

[Maximiliano Sandoval]

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 js/DKIMSettings.js       | 2 +-
 js/MyNetworks.js         | 4 ++--
 js/QuarantineList.js     | 2 +-
 js/UserBlackWhiteList.js | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/js/DKIMSettings.js b/js/DKIMSettings.js
index d905a74..9cebfeb 100644
--- a/js/DKIMSettings.js
+++ b/js/DKIMSettings.js
@@ -37,7 +37,7 @@ Ext.define('PMG.DKIMEnableEdit', {
 		},
 		success: function(response, opts) {
 		    if (!Ext.isDefined(response.result.data.record)) {
-			disablefn('Could not read private key - please create a selector first!');
+			disablefn(gettext('Could not read private key - please create a selector first!'));
 		    }
 		},
 	    });
diff --git a/js/MyNetworks.js b/js/MyNetworks.js
index 975e21d..22a8577 100644
--- a/js/MyNetworks.js
+++ b/js/MyNetworks.js
@@ -51,7 +51,7 @@ Ext.define('PMG.MyNetworks', {
 		    {
 			xtype: 'displayfield',
 			name: 'cidr',
-			fieldLabel: 'CIDR',
+			fieldLabel: gettext('CIDR'),
 		    },
 		    {
 			xtype: 'textfield',
@@ -89,7 +89,7 @@ Ext.define('PMG.MyNetworks', {
 			    {
 				xtype: 'proxmoxtextfield',
 				name: 'cidr',
-				fieldLabel: 'CIDR',
+				fieldLabel: gettext('CIDR'),
 			    },
 			    {
 				xtype: 'proxmoxtextfield',
diff --git a/js/QuarantineList.js b/js/QuarantineList.js
index faeacd6..01b466d 100644
--- a/js/QuarantineList.js
+++ b/js/QuarantineList.js
@@ -359,7 +359,7 @@ Ext.define('PMG.QuarantineList', {
 		anyMatch: true,
 		selectOnFocus: true,
 		reference: 'email',
-		fieldLabel: 'E-Mail',
+		fieldLabel: gettext('E-Mail'),
 		triggers: {
 		    clear: {
 			cls: 'pmx-clear-trigger',
diff --git a/js/UserBlackWhiteList.js b/js/UserBlackWhiteList.js
index 1344496..6cc6b10 100644
--- a/js/UserBlackWhiteList.js
+++ b/js/UserBlackWhiteList.js
@@ -153,7 +153,7 @@ Ext.define('PMG.UserBlackWhiteList', {
 		gettext('No data in database') +
 		'</div>',
 	    },
-	    fieldLabel: 'E-Mail',
+	    fieldLabel: gettext('E-Mail'),
 	},
 	{
 	    text: gettext('Add'),
-- 
2.39.2

[pmg-devel] [PATCH pmg-gui 2/2] NavigationTree: Remove extra space

[Maximiliano Sandoval]

The new string already is in our .po file. This change will remove the
wrong string without requiring newer translations.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 js/NavigationTree.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/js/NavigationTree.js b/js/NavigationTree.js
index 2c4d5a5..59d98f5 100644
--- a/js/NavigationTree.js
+++ b/js/NavigationTree.js
@@ -163,7 +163,7 @@ Ext.define('PMG.store.NavigationStore', {
 			leaf: true,
 		    },
 		    {
-			text: gettext('Virus  Charts'),
+			text: gettext('Virus Charts'),
 			iconCls: 'fa fa-bug',
 			path: 'pmgVirusCharts',
 			leaf: true,
-- 
2.39.2

[pmg-devel] applied-series: [PATCH pmg-gui 1/2] gui: Mark missing strings as translatable

[Stoiko Ivanov]

applied both patches - Thanks!

On Wed, Nov 29, 2023 at 02:25:21PM +0100, Maximiliano Sandoval wrote:
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  js/DKIMSettings.js       | 2 +-
>  js/MyNetworks.js         | 4 ++--
>  js/QuarantineList.js     | 2 +-
>  js/UserBlackWhiteList.js | 2 +-
>  4 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/js/DKIMSettings.js b/js/DKIMSettings.js
> index d905a74..9cebfeb 100644
> --- a/js/DKIMSettings.js
> +++ b/js/DKIMSettings.js
> @@ -37,7 +37,7 @@ Ext.define('PMG.DKIMEnableEdit', {
>  		},
>  		success: function(response, opts) {
>  		    if (!Ext.isDefined(response.result.data.record)) {
> -			disablefn('Could not read private key - please create a selector first!');
> +			disablefn(gettext('Could not read private key - please create a selector first!'));
>  		    }
>  		},
>  	    });
> diff --git a/js/MyNetworks.js b/js/MyNetworks.js
> index 975e21d..22a8577 100644
> --- a/js/MyNetworks.js
> +++ b/js/MyNetworks.js
> @@ -51,7 +51,7 @@ Ext.define('PMG.MyNetworks', {
>  		    {
>  			xtype: 'displayfield',
>  			name: 'cidr',
> -			fieldLabel: 'CIDR',
> +			fieldLabel: gettext('CIDR'),
>  		    },
>  		    {
>  			xtype: 'textfield',
> @@ -89,7 +89,7 @@ Ext.define('PMG.MyNetworks', {
>  			    {
>  				xtype: 'proxmoxtextfield',
>  				name: 'cidr',
> -				fieldLabel: 'CIDR',
> +				fieldLabel: gettext('CIDR'),
>  			    },
>  			    {
>  				xtype: 'proxmoxtextfield',
> diff --git a/js/QuarantineList.js b/js/QuarantineList.js
> index faeacd6..01b466d 100644
> --- a/js/QuarantineList.js
> +++ b/js/QuarantineList.js
> @@ -359,7 +359,7 @@ Ext.define('PMG.QuarantineList', {
>  		anyMatch: true,
>  		selectOnFocus: true,
>  		reference: 'email',
> -		fieldLabel: 'E-Mail',
> +		fieldLabel: gettext('E-Mail'),
>  		triggers: {
>  		    clear: {
>  			cls: 'pmx-clear-trigger',
> diff --git a/js/UserBlackWhiteList.js b/js/UserBlackWhiteList.js
> index 1344496..6cc6b10 100644
> --- a/js/UserBlackWhiteList.js
> +++ b/js/UserBlackWhiteList.js
> @@ -153,7 +153,7 @@ Ext.define('PMG.UserBlackWhiteList', {
>  		gettext('No data in database') +
>  		'</div>',
>  	    },
> -	    fieldLabel: 'E-Mail',
> +	    fieldLabel: gettext('E-Mail'),
>  	},
>  	{
>  	    text: gettext('Add'),
> -- 
> 2.39.2
> 
> 
> 
> _______________________________________________
> pmg-devel mailing list
> pmg-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
> 
>