public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] [PATCH pmg-gui v3 2/2] mail-proxy-relaying: add help to Default Relay
Date: Thu, 14 Sep 2023 15:18:13 +0200	[thread overview]
Message-ID: <20230914131813.3143701-2-m.sandoval@proxmox.com> (raw)
In-Reply-To: <20230914131813.3143701-1-m.sandoval@proxmox.com>

Add link to [1].

[1] https://pmg.proxmox.com/pmg-docs/chapter-pmgconfig.html#pmgconfig_mailproxy_relaying

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
Differences from v2:
  - Add the link to all buttons in this panel.

 js/MailProxyRelaying.js | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/js/MailProxyRelaying.js b/js/MailProxyRelaying.js
index 411c9b4..8b91aef 100644
--- a/js/MailProxyRelaying.js
+++ b/js/MailProxyRelaying.js
@@ -10,6 +10,7 @@ Ext.define('PMG.MailProxyRelaying', {
 	me.add_text_row('relay', gettext('Default Relay'), {
 	    deleteEmpty: true,
 	    defaultValue: Proxmox.Utils.noneText,
+	    onlineHelp: 'pmgconfig_mailproxy_relaying',
 	});
 
 	me.add_integer_row('relayport', gettext('Relay Port'), {
@@ -17,6 +18,7 @@ Ext.define('PMG.MailProxyRelaying', {
 	    deleteEmpty: true,
 	    minValue: 1,
 	    maxValue: 65535,
+	    onlineHelp: 'pmgconfig_mailproxy_relaying',
 	});
 
 	me.add_combobox_row('relayprotocol', gettext('Relay Protocol'), {
@@ -24,10 +26,13 @@ Ext.define('PMG.MailProxyRelaying', {
 	    comboItems: [
 	    ['smtp', 'SMTP'],
 	    ['lmtp', 'LMTP']],
+	    onlineHelp: 'pmgconfig_mailproxy_relaying',
 	});
 
 
-	me.add_boolean_row('relaynomx', gettext('Disable MX lookup (SMTP)'));
+	me.add_boolean_row('relaynomx', gettext('Disable MX lookup (SMTP)'), {
+	    onlineHelp: 'pmgconfig_mailproxy_relaying',
+	});
 
 	me.rows.smarthost = {
 	    required: true,
@@ -79,6 +84,7 @@ Ext.define('PMG.MailProxyRelaying', {
 		    },
 		],
 	    },
+	    onlineHelp: 'pmgconfig_mailproxy_relaying',
 	};
 
 	me.rows.smarthostport = { visible: false };
-- 
2.39.2





  reply	other threads:[~2023-09-14 13:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-14 13:18 [pmg-devel] [PATCH pmg-gui v3 1/2] mail-proxy-relaying: format function arguments Maximiliano Sandoval
2023-09-14 13:18 ` Maximiliano Sandoval [this message]
2023-12-14 14:02   ` [pmg-devel] [PATCH pmg-gui v3 2/2] mail-proxy-relaying: add help to Default Relay Maximiliano Sandoval
2023-12-15 15:31 ` [pmg-devel] applied-series: [PATCH pmg-gui v3 1/2] mail-proxy-relaying: format function arguments Stoiko Ivanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230914131813.3143701-2-m.sandoval@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal