public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: Maximiliano Sandoval <m.sandoval@proxmox.com>
Cc: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] applied: [PATCH pmg-api v2] fix #4944: api/pbs remote: Add a port config
Date: Tue, 12 Sep 2023 16:41:35 +0200	[thread overview]
Message-ID: <20230912164135.7271fbb4@rosa.proxmox.com> (raw)
In-Reply-To: <20230904135437.262664-1-m.sandoval@proxmox.com>

Thanks for the patch!
applied to master


On Mon,  4 Sep 2023 15:54:37 +0200
Maximiliano Sandoval <m.sandoval@proxmox.com> wrote:

> Allows to set a port via
> 
>     pmgbackup proxmox-backup remote set REMOTE --port PORT
> 
> The client perl-module is shared with Proxmox VE, where the required
> bits for this to work are already implemented.
> 
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> Differences from v1:
>   - Added minimum, maximum, default values
>   - Improved description
>   - Added more info to the commit msg
> 
>  src/PMG/PBSConfig.pm | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/src/PMG/PBSConfig.pm b/src/PMG/PBSConfig.pm
> index ee506f1..998e960 100644
> --- a/src/PMG/PBSConfig.pm
> +++ b/src/PMG/PBSConfig.pm
> @@ -96,6 +96,14 @@ sub properties {
>  	    type => 'string',
>  	    optional => 1,
>  	},
> +	port => {
> +	    description => "Non-default port for Proxmox Backup Server.",
> +	    optional => 1,
> +	    type => 'integer',
> +	    minimum => 1,
> +	    maximum => 65535,
> +	    default => 8007,
> +	},
>  	username => get_standard_option('pmg-email-address', {
>  	    description => "Username or API token ID on the Proxmox Backup Server"
>  	}),
> @@ -123,6 +131,7 @@ sub options {
>  	disable => { optional => 1 },
>  	username => { optional => 1 },
>  	password => { optional => 1 },
> +	port => { optional => 1 },
>  	fingerprint => { optional => 1 },
>  	notify => { optional => 1 },
>  	'include-statistics' => { optional => 1 },





      reply	other threads:[~2023-09-12 14:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-04 13:54 [pmg-devel] " Maximiliano Sandoval
2023-09-12 14:41 ` Stoiko Ivanov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230912164135.7271fbb4@rosa.proxmox.com \
    --to=s.ivanov@proxmox.com \
    --cc=m.sandoval@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal