[pmg-devel] [PATCH pmg-gui 1/2] mail-proxy-relaying: format function arguments

[pmg-devel] [PATCH pmg-gui 1/2] mail-proxy-relaying: format function arguments

[Maximiliano Sandoval]

In the next commit we add a new parameter.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 js/MailProxyRelaying.js | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/js/MailProxyRelaying.js b/js/MailProxyRelaying.js
index ace9575..411c9b4 100644
--- a/js/MailProxyRelaying.js
+++ b/js/MailProxyRelaying.js
@@ -7,8 +7,10 @@ Ext.define('PMG.MailProxyRelaying', {
     initComponent: function() {
 	var me = this;
 
-	me.add_text_row('relay', gettext('Default Relay'),
-			{ deleteEmpty: true, defaultValue: Proxmox.Utils.noneText });
+	me.add_text_row('relay', gettext('Default Relay'), {
+	    deleteEmpty: true,
+	    defaultValue: Proxmox.Utils.noneText,
+	});
 
 	me.add_integer_row('relayport', gettext('Relay Port'), {
 	    defaultValue: 25,
-- 
2.39.2

[pmg-devel] [PATCH pmg-gui 2/2] mail-proxy-relaying: add help to Default Relay

[Maximiliano Sandoval]

Add link to [1]. This is quite an important setting, might as well
provide documentation.

[1] https://pmg.proxmox.com/pmg-docs/chapter-pmgconfig.html#pmgconfig_mailproxy_relaying

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 js/MailProxyRelaying.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/js/MailProxyRelaying.js b/js/MailProxyRelaying.js
index 411c9b4..c9fafbe 100644
--- a/js/MailProxyRelaying.js
+++ b/js/MailProxyRelaying.js
@@ -10,6 +10,7 @@ Ext.define('PMG.MailProxyRelaying', {
 	me.add_text_row('relay', gettext('Default Relay'), {
 	    deleteEmpty: true,
 	    defaultValue: Proxmox.Utils.noneText,
+	    onlineHelp: 'pmgconfig_mailproxy_relaying',
 	});
 
 	me.add_integer_row('relayport', gettext('Relay Port'), {
-- 
2.39.2

Re: [pmg-devel] [PATCH pmg-gui 2/2] mail-proxy-relaying: add help to Default Relay

[Stoiko Ivanov]

Thanks for the addition - LGTM in general.

One question remains - why only add it here and not also the the other
editors (port, protocol, nomx)?


On Thu,  7 Sep 2023 15:47:04 +0200
Maximiliano Sandoval <m.sandoval@proxmox.com> wrote:

> Add link to [1]. This is quite an important setting, might as well
> provide documentation.
> 
> [1] https://pmg.proxmox.com/pmg-docs/chapter-pmgconfig.html#pmgconfig_mailproxy_relaying
> 
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  js/MailProxyRelaying.js | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/js/MailProxyRelaying.js b/js/MailProxyRelaying.js
> index 411c9b4..c9fafbe 100644
> --- a/js/MailProxyRelaying.js
> +++ b/js/MailProxyRelaying.js
> @@ -10,6 +10,7 @@ Ext.define('PMG.MailProxyRelaying', {
>  	me.add_text_row('relay', gettext('Default Relay'), {
>  	    deleteEmpty: true,
>  	    defaultValue: Proxmox.Utils.noneText,
> +	    onlineHelp: 'pmgconfig_mailproxy_relaying',
>  	});
>  
>  	me.add_integer_row('relayport', gettext('Relay Port'), {

Re: [pmg-devel] [PATCH pmg-gui 2/2] mail-proxy-relaying: add help to Default Relay

[Maximiliano Sandoval]

On 9/12/23 16:22, Stoiko Ivanov wrote:
> Thanks for the addition - LGTM in general.
>
> One question remains - why only add it here and not also the the other
> editors (port, protocol, nomx)?

That could be the material of a follow up. To be honest I only touched this one
since it was the one I needed when testing a Proxmox Mail Gateway but didn't
have the documentation on the UI when I needed it.