From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: Maximiliano Sandoval <m.sandoval@proxmox.com>
Cc: pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH pmg-gui 2/2] mail-proxy-relaying: add help to Default Relay
Date: Tue, 12 Sep 2023 16:22:54 +0200 [thread overview]
Message-ID: <20230912162254.1956be7b@rosa.proxmox.com> (raw)
In-Reply-To: <20230907134704.164144-2-m.sandoval@proxmox.com>
Thanks for the addition - LGTM in general.
One question remains - why only add it here and not also the the other
editors (port, protocol, nomx)?
On Thu, 7 Sep 2023 15:47:04 +0200
Maximiliano Sandoval <m.sandoval@proxmox.com> wrote:
> Add link to [1]. This is quite an important setting, might as well
> provide documentation.
>
> [1] https://pmg.proxmox.com/pmg-docs/chapter-pmgconfig.html#pmgconfig_mailproxy_relaying
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> js/MailProxyRelaying.js | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/js/MailProxyRelaying.js b/js/MailProxyRelaying.js
> index 411c9b4..c9fafbe 100644
> --- a/js/MailProxyRelaying.js
> +++ b/js/MailProxyRelaying.js
> @@ -10,6 +10,7 @@ Ext.define('PMG.MailProxyRelaying', {
> me.add_text_row('relay', gettext('Default Relay'), {
> deleteEmpty: true,
> defaultValue: Proxmox.Utils.noneText,
> + onlineHelp: 'pmgconfig_mailproxy_relaying',
> });
>
> me.add_integer_row('relayport', gettext('Relay Port'), {
next prev parent reply other threads:[~2023-09-12 14:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 13:47 [pmg-devel] [PATCH pmg-gui 1/2] mail-proxy-relaying: format function arguments Maximiliano Sandoval
2023-09-07 13:47 ` [pmg-devel] [PATCH pmg-gui 2/2] mail-proxy-relaying: add help to Default Relay Maximiliano Sandoval
2023-09-12 14:22 ` Stoiko Ivanov [this message]
2023-09-12 15:02 ` Maximiliano Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230912162254.1956be7b@rosa.proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox