public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] [PATCH pmg-gui v3] backup-configuration: Add icons to tab buttons
Date: Wed,  6 Sep 2023 15:09:07 +0200	[thread overview]
Message-ID: <20230906130907.2036832-1-m.sandoval@proxmox.com> (raw)

From a UX perspective flat buttons, i.e. buttons without a frame or
background, are not obviously clickable without an icon.

The choice of icons was taken from pve-manager's Utils.js module.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
Differences from v2:
  - Use folder icon as suggest in v2 of the patch
  - Improved commit message

 js/BackupConfiguration.js | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/js/BackupConfiguration.js b/js/BackupConfiguration.js
index e21771f..ed9959c 100644
--- a/js/BackupConfiguration.js
+++ b/js/BackupConfiguration.js
@@ -12,11 +12,13 @@ Ext.define('PMG.BackupConfiguration', {
 	    itemId: 'local',
 	    title: gettext('Local Backup/Restore'),
 	    xtype: 'pmgBackupRestore',
+	    iconCls: 'fa fa-folder',
 	},
 	{
 	    itemId: 'proxmoxbackupserver',
 	    title: 'Proxmox Backup Server',
 	    xtype: 'pmgPBSConfig',
+	    iconCls: 'fa fa-floppy-o',
 	},
    ],
 });
-- 
2.39.2





             reply	other threads:[~2023-09-06 13:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-06 13:09 Maximiliano Sandoval [this message]
2023-09-07  6:33 ` [pmg-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230906130907.2036832-1-m.sandoval@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal