[pmg-devel] [PATCH pmg-api v2] fix #4944: api/pbs remote: Add a port config

[pmg-devel] [PATCH pmg-api v2] fix #4944: api/pbs remote: Add a port config

[Maximiliano Sandoval]

Allows to set a port via

    pmgbackup proxmox-backup remote set REMOTE --port PORT

The client perl-module is shared with Proxmox VE, where the required
bits for this to work are already implemented.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
Differences from v1:
  - Added minimum, maximum, default values
  - Improved description
  - Added more info to the commit msg

 src/PMG/PBSConfig.pm | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/src/PMG/PBSConfig.pm b/src/PMG/PBSConfig.pm
index ee506f1..998e960 100644
--- a/src/PMG/PBSConfig.pm
+++ b/src/PMG/PBSConfig.pm
@@ -96,6 +96,14 @@ sub properties {
 	    type => 'string',
 	    optional => 1,
 	},
+	port => {
+	    description => "Non-default port for Proxmox Backup Server.",
+	    optional => 1,
+	    type => 'integer',
+	    minimum => 1,
+	    maximum => 65535,
+	    default => 8007,
+	},
 	username => get_standard_option('pmg-email-address', {
 	    description => "Username or API token ID on the Proxmox Backup Server"
 	}),
@@ -123,6 +131,7 @@ sub options {
 	disable => { optional => 1 },
 	username => { optional => 1 },
 	password => { optional => 1 },
+	port => { optional => 1 },
 	fingerprint => { optional => 1 },
 	notify => { optional => 1 },
 	'include-statistics' => { optional => 1 },
-- 
2.39.2

[pmg-devel] applied: [PATCH pmg-api v2] fix #4944: api/pbs remote: Add a port config

[Stoiko Ivanov]

Thanks for the patch!
applied to master


On Mon,  4 Sep 2023 15:54:37 +0200
Maximiliano Sandoval <m.sandoval@proxmox.com> wrote:

> Allows to set a port via
> 
>     pmgbackup proxmox-backup remote set REMOTE --port PORT
> 
> The client perl-module is shared with Proxmox VE, where the required
> bits for this to work are already implemented.
> 
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> Differences from v1:
>   - Added minimum, maximum, default values
>   - Improved description
>   - Added more info to the commit msg
> 
>  src/PMG/PBSConfig.pm | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/src/PMG/PBSConfig.pm b/src/PMG/PBSConfig.pm
> index ee506f1..998e960 100644
> --- a/src/PMG/PBSConfig.pm
> +++ b/src/PMG/PBSConfig.pm
> @@ -96,6 +96,14 @@ sub properties {
>  	    type => 'string',
>  	    optional => 1,
>  	},
> +	port => {
> +	    description => "Non-default port for Proxmox Backup Server.",
> +	    optional => 1,
> +	    type => 'integer',
> +	    minimum => 1,
> +	    maximum => 65535,
> +	    default => 8007,
> +	},
>  	username => get_standard_option('pmg-email-address', {
>  	    description => "Username or API token ID on the Proxmox Backup Server"
>  	}),
> @@ -123,6 +131,7 @@ sub options {
>  	disable => { optional => 1 },
>  	username => { optional => 1 },
>  	password => { optional => 1 },
> +	port => { optional => 1 },
>  	fingerprint => { optional => 1 },
>  	notify => { optional => 1 },
>  	'include-statistics' => { optional => 1 },