[pmg-devel] [PATCH pmg-api] fix #4944: api/pbs remote: Add a port config

[pmg-devel] [PATCH pmg-api] fix #4944: api/pbs remote: Add a port config

[Maximiliano Sandoval]

Allows to set a port via

    pmgbackup proxmox-backup remote set REMOTE --port PORT

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 Tested both via
   - pmgbackup proxmox-backup backup REMOTE
   - webui

 src/PMG/PBSConfig.pm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/PMG/PBSConfig.pm b/src/PMG/PBSConfig.pm
index ee506f1..4431e43 100644
--- a/src/PMG/PBSConfig.pm
+++ b/src/PMG/PBSConfig.pm
@@ -96,6 +96,11 @@ sub properties {
 	    type => 'string',
 	    optional => 1,
 	},
+	port => {
+	    description => "Proxmox Backup Server port.",
+	    optional => 1,
+	    type => 'integer',
+	},
 	username => get_standard_option('pmg-email-address', {
 	    description => "Username or API token ID on the Proxmox Backup Server"
 	}),
@@ -123,6 +128,7 @@ sub options {
 	disable => { optional => 1 },
 	username => { optional => 1 },
 	password => { optional => 1 },
+	port => { optional => 1 },
 	fingerprint => { optional => 1 },
 	notify => { optional => 1 },
 	'include-statistics' => { optional => 1 },
-- 
2.39.2

Re: [pmg-devel] [PATCH pmg-api] fix #4944: api/pbs remote: Add a port config

[Stoiko Ivanov]

Thanks for tackling this so quickly!

two tiny nits inline:
On Mon,  4 Sep 2023 13:52:27 +0200
Maximiliano Sandoval <m.sandoval@proxmox.com> wrote:

> Allows to set a port via
> 
>     pmgbackup proxmox-backup remote set REMOTE --port PORT
you might mention that the client perl-module is shared with PVE, where
this is already possible/implemented

> 
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  Tested both via
>    - pmgbackup proxmox-backup backup REMOTE
>    - webui
> 
>  src/PMG/PBSConfig.pm | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/src/PMG/PBSConfig.pm b/src/PMG/PBSConfig.pm
> index ee506f1..4431e43 100644
> --- a/src/PMG/PBSConfig.pm
> +++ b/src/PMG/PBSConfig.pm
> @@ -96,6 +96,11 @@ sub properties {
>  	    type => 'string',
>  	    optional => 1,
>  	},
> +	port => {
> +	    description => "Proxmox Backup Server port.",
> +	    optional => 1,
> +	    type => 'integer',
> +	},
you might want to add the additional information we already have in PVE:
https://git.proxmox.com/?p=pve-storage.git;a=blob;f=src/PVE/Storage/PBSPlugin.pm;h=4320974b6b9c03c6ce4b722fb6b7d06550c7f359;hb=HEAD#l52


>  	username => get_standard_option('pmg-email-address', {
>  	    description => "Username or API token ID on the Proxmox Backup Server"
>  	}),
> @@ -123,6 +128,7 @@ sub options {
>  	disable => { optional => 1 },
>  	username => { optional => 1 },
>  	password => { optional => 1 },
> +	port => { optional => 1 },
>  	fingerprint => { optional => 1 },
>  	notify => { optional => 1 },
>  	'include-statistics' => { optional => 1 },