From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] [PATCH pmg-api 0/4] add notification about unmodified template-overrides
Date: Fri, 7 Jul 2023 18:54:24 +0200 [thread overview]
Message-ID: <20230707165428.94777-1-s.ivanov@proxmox.com> (raw)
This patch series adds functionality to notify users and our support about
templates copied to /etc/pmg/templates, without any changes.
While I thought initially that this could lead to actual issues (as the
unmodified templates from an old version mask the changes we provide in
the package) - this is luckily handled gracefully by ucf (which simply
overwrites the unmodified version in /etc/pmg/templates, by the new one in
/var/lib/pmg/templates.)
The merit of the series is (at least) that it should now be easier to see
actually relevant changes in the templates in our support-channels
(through the updated report).
if applied - it would make sense to also apply this to stable-7
Stoiko Ivanov (4):
utils: add helper for unmodified templates
pmg7to8: notify about unmodified templates
report: skip irrelevant files in /etc/pmg/templates
report: group use statements
src/PMG/CLI/pmg7to8.pm | 6 ++++++
src/PMG/Report.pm | 28 ++++++++++++++++++++++++++--
src/PMG/Utils.pm | 20 ++++++++++++++++++++
3 files changed, 52 insertions(+), 2 deletions(-)
--
2.39.2
next reply other threads:[~2023-07-07 16:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 16:54 Stoiko Ivanov [this message]
2023-07-07 16:54 ` [pmg-devel] [PATCH pmg-api 1/4] utils: add helper for unmodified templates Stoiko Ivanov
2023-07-10 10:02 ` Thomas Lamprecht
2023-07-07 16:54 ` [pmg-devel] [PATCH pmg-api 2/4] pmg7to8: notify about " Stoiko Ivanov
2023-07-11 15:20 ` [pmg-devel] applied: " Thomas Lamprecht
2023-07-07 16:54 ` [pmg-devel] [PATCH pmg-api 3/4] report: skip irrelevant files in /etc/pmg/templates Stoiko Ivanov
2023-07-11 15:20 ` [pmg-devel] applied: " Thomas Lamprecht
2023-07-07 16:54 ` [pmg-devel] [PATCH pmg-api 4/4] report: group use statements Stoiko Ivanov
2023-07-11 15:19 ` [pmg-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230707165428.94777-1-s.ivanov@proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox