From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] [RFC pmg-log-tracker 0/2] fix rfc3339 output from logtracker
Date: Tue, 27 Jun 2023 21:46:48 +0200 [thread overview]
Message-ID: <20230627194650.34027-1-s.ivanov@proxmox.com> (raw)
while upgrading a few systems we found a small glitch in the new timeformat
parsing: it did not account for the lack of timezone information in
the traditional syslog (which the API fixes up by subtracting its local
offset).
The mails were displayed in the log-tracker - but their times were UTC
(e.g. a mail from 19:37 was displayed at 17:37).
The 2 patches work around the issue as a stop-gap - by re-adding the offset
again to the parsed offset.
It seems like a better tradeoff than reworking the parsing of traditional
syslog format (which we want to drop soon anyways) - and adapting the API
(to trust the data from pmg-log-tracker)
Sending as RFC, because the code can benefit from some rework by people more
familiar with rust.
Stoiko Ivanov (2):
rfc3339 timestamps: counter-offset timezone
tests: update rfc3339 testoutput
src/main.rs | 27 +++++++++++++++++++++++----
tests/test_output_time_rfc3339_mixed | 20 ++++++++++----------
2 files changed, 33 insertions(+), 14 deletions(-)
--
2.39.2
next reply other threads:[~2023-06-27 19:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 19:46 Stoiko Ivanov [this message]
2023-06-27 19:46 ` [pmg-devel] [RFC pmg-log-tracker 1/2] rfc3339 timestamps: counter-offset timezone Stoiko Ivanov
2023-06-28 7:27 ` Dominik Csapak
2023-06-27 19:46 ` [pmg-devel] [RFC pmg-log-tracker 2/2] tests: update rfc3339 testoutput Stoiko Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230627194650.34027-1-s.ivanov@proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox