From: Dominik Csapak <d.csapak@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] [PATCH pmg-gui] fix tracking center with newer proxmox-widget-toolkit
Date: Mon, 26 Jun 2023 16:52:53 +0200 [thread overview]
Message-ID: <20230626145253.2014568-1-d.csapak@proxmox.com> (raw)
newer widget-toolkit versions did change the DateTimeField a bit, and
now breaks when there is no viewModel anywhere, so add one as a stopgap
fix for now in the tracking center.
the real fix would have to be in DateTimeField itself, probably checking
if there is a bind.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
I just did not have time today to look into the code in
widget-toolkit. if someone finds an easy solution there go ahead, but
this should be fine as a stopgap...
js/MailTracker.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/js/MailTracker.js b/js/MailTracker.js
index 52641a4..1a170d8 100644
--- a/js/MailTracker.js
+++ b/js/MailTracker.js
@@ -38,6 +38,8 @@ Ext.define('PMG.MailTrackerFilter', {
},
},
+ viewModel: {},
+
getFilterParams: function() {
let me = this;
let param = {};
--
2.30.2
next reply other threads:[~2023-06-26 14:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-26 14:52 Dominik Csapak [this message]
2023-06-27 11:39 ` [pmg-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230626145253.2014568-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox