From: Dominik Csapak <d.csapak@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] [PATCH pmg-api/gui] perparations and breaking changes
Date: Fri, 23 Jun 2023 14:20:59 +0200 [thread overview]
Message-ID: <20230623122104.2411099-1-d.csapak@proxmox.com> (raw)
in bookworm, postgres15 has more restrictive permissions, so we have to
adapt to that
in addition, we want to disable some options by default, namely:
advfiler (advances statistic filters)
use_bayes
use_awl (auto-whitelist)
these patches simply change default in the config & frontent, so these
are breaking changes. To deal with that we have (at least) these three
possibilities:
* simply document them in the upgrade guide
easiest for us, but has *some* potential for issues when users
don't properly read/follow them and their bayes/awl db get's deleted
* use preinst/postinst script to set the old defaults as explicit values
in the config. this shouldn't be too hard, but is some baggage
that we have to keep until the next major version
* introduce a pmg7to8 tool like for pve
it's the most work, but we could potentiall use this also for
detecting misconfigurations, add warnings e.g. about templates, not
running postgres instances (or still running old instances after the
upgrade), not current packages, etc.
pmg-api:
Dominik Csapak (3):
dbtools: grant permissions public schema for created databases
config: disable awl and bayes by default
config: disable advanced statistic filters by default
src/PMG/Config.pm | 6 +++---
src/PMG/DBTools.pm | 8 ++++++++
2 files changed, 11 insertions(+), 3 deletions(-)
pmg-gui:
Dominik Csapak (2):
configuration: options: adapt to new advanced statistic filter default
spam: options: adapt do new defaults for bayes/awl
js/SpamDetectorOptions.js | 4 ++--
js/SystemOptions.js | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
--
2.30.2
next reply other threads:[~2023-06-23 12:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-23 12:20 Dominik Csapak [this message]
2023-06-23 12:21 ` [pmg-devel] [PATCH pmg-api 1/3] dbtools: grant permissions public schema for created databases Dominik Csapak
2023-06-26 8:47 ` Stoiko Ivanov
2023-06-23 12:21 ` [pmg-devel] [PATCH pmg-api 2/3] config: disable awl and bayes by default Dominik Csapak
2023-06-26 13:21 ` [pmg-devel] applied: " Thomas Lamprecht
2023-06-23 12:21 ` [pmg-devel] [PATCH pmg-api 3/3] config: disable advanced statistic filters " Dominik Csapak
2023-06-26 13:21 ` [pmg-devel] applied: " Thomas Lamprecht
2023-06-23 12:21 ` [pmg-devel] [PATCH pmg-gui 1/2] configuration: options: adapt to new advanced statistic filter default Dominik Csapak
2023-06-26 13:27 ` [pmg-devel] applied: " Thomas Lamprecht
2023-06-23 12:21 ` [pmg-devel] [PATCH pmg-gui 2/2] spam: options: adapt do new defaults for bayes/awl Dominik Csapak
2023-06-26 13:27 ` [pmg-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230623122104.2411099-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox