public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] [RFC PATCH pmg-api] api: cluster status: add timeout to api call
Date: Mon, 17 Apr 2023 13:40:35 +0200	[thread overview]
Message-ID: <20230417114035.3051763-1-d.csapak@proxmox.com> (raw)

we query each other host in the cluster for it's status, but if we reach
the 30s limit of the pmgproxy, we get a

 communication failure(0)

error in the gui. To prevent this, add a (much) shorter timeout to each
api call, which makes sure that the whole status call succeeds.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
sending as RFC because i am not sure if this is the best approach:
we could have very asymmetric http call times, which would maybe
all go through without timeout, but we cannot really know that
beforehand.

Another approach could be to give as much time as we have left (with
buffer) and subtract the time we took for each call. This would be a
problem if the first takes so long that we don't have any time left
for the other calls...

 src/PMG/API2/Cluster.pm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/PMG/API2/Cluster.pm b/src/PMG/API2/Cluster.pm
index 84dafab..5e0a987 100644
--- a/src/PMG/API2/Cluster.pm
+++ b/src/PMG/API2/Cluster.pm
@@ -217,6 +217,9 @@ __PACKAGE__->register_method({
 	    $res = [ $ni ];
 	}
 
+	# 30 seconds minus 5 seconds buffer time, split evenly for the other hosts
+	my $timeout = 25 / (scalar(@$res) - 1);
+
 	my $rpcenv = PMG::RESTEnvironment->get();
         my $authuser = $rpcenv->get_user();
 	my $ticket = $rpcenv->get_ticket();
@@ -231,6 +234,7 @@ __PACKAGE__->register_method({
 			ticket => $ticket,
 			cookie_name => 'PMGAuthCookie',
 			host => $ni->{ip},
+			timeout => $timeout,
 			cached_fingerprints => {
 			    $ni->{fingerprint} => 1,
 			});
-- 
2.30.2





             reply	other threads:[~2023-04-17 11:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-17 11:40 Dominik Csapak [this message]
2023-05-17 10:36 ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230417114035.3051763-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal