Re: [pmg-devel] applied-series: [PATCH spamassassin/pmg-api ] ship complete KAM ruleset

[Stoiko Ivanov <s.ivanov@proxmox.com>]

On Sun, 26 Mar 2023 18:11:41 +0200
Thomas Lamprecht <t.lamprecht@proxmox.com> wrote:

> Am 24/03/2023 um 13:46 schrieb Stoiko Ivanov:
> > A few warnings were observed, when upgrading to proxmox-spamassassin 4.0
> > and to a pmg-api > 7.2-5:
> > * the sa-rules we ship in proxmox-spamassassin still recorded SA version
> >   3.4.6 and spamassassin warned about that - this is fixed independently,
> >   by pushing updates SA rules directly (after running our
> >   regression_tests)
> > * the KAM.cf file as of recently depends on the other files in the
> >   complete ruleset as well:
> >   ```
> >   WARNING: HashBL: PCCC_HASHBL_FREEMAIL acl 'freemail' not defined
> >   ```
> > 
> > This patchset addresses the latter issue by shipping the complete KAM
> > ruleset with each proxmox-spamassassin package.
> > The download using sa-update is based on the code in pmg-api, which does
> > the same in pmg-daily
> > 
> > I'm sending only the actual code and doc changes - and, if approved, would
> > push the actual rule-update and removal directly instead of sending
> > multiple megabytes of spamassassin rule definitions (which would not pass
> > our mail-gateway anyways :)  
> 
> just push it to a staff repo or the like next time, then I can
> pull all and could have bumped this now already ;-)

dunno why I did not do that ... - sorry for causing more work

pushed the ruleset I tested with.

Thanks for checking the patches!

> 
> > 
> > testing this is best done by applying the patches and running
> > `make update-kam`
> > 
> > With using kam_sa-channels_mcgrail_com.cf to include all files in the
> > ruleset the adaptation of the local.cf template (pmg-api patch 1/1) would
> > need a versioned dependeny bump on proxmox-spamassassin
> > 
> > In my tests spamassassin (pmg-smtp-filter) quite happily ignored the
> > missing /usr/share/spamassassin-extra/KAM.cf file - so a Breaks in the
> > other direction should not be needed.
> > 
> > proxmox-spamassassin:
> > Stoiko Ivanov (2):
> >   kam-rules: ship full ruleset not only KAM.cf
> >   buildsys: update outdated docs on updating rulesets
> > 
> >  Makefile | 41 +++++++++++++++++------------------------
> >  1 file changed, 17 insertions(+), 24 deletions(-)
> > 
> > pmg-api:
> > Stoiko Ivanov (1):
> >   templates: adapt to new path for KAM rules in proxmox-spamassassin
> > 
> >  src/templates/local.cf.in | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >   
> 
> 
> applied, thanks!