public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] [PATCH spamassassin/pmg-api ] ship complete KAM ruleset
Date: Fri, 24 Mar 2023 13:46:52 +0100	[thread overview]
Message-ID: <20230324124655.39567-1-s.ivanov@proxmox.com> (raw)

A few warnings were observed, when upgrading to proxmox-spamassassin 4.0
and to a pmg-api > 7.2-5:
* the sa-rules we ship in proxmox-spamassassin still recorded SA version
  3.4.6 and spamassassin warned about that - this is fixed independently,
  by pushing updates SA rules directly (after running our
  regression_tests)
* the KAM.cf file as of recently depends on the other files in the
  complete ruleset as well:
  ```
  WARNING: HashBL: PCCC_HASHBL_FREEMAIL acl 'freemail' not defined
  ```

This patchset addresses the latter issue by shipping the complete KAM
ruleset with each proxmox-spamassassin package.
The download using sa-update is based on the code in pmg-api, which does
the same in pmg-daily

I'm sending only the actual code and doc changes - and, if approved, would
push the actual rule-update and removal directly instead of sending
multiple megabytes of spamassassin rule definitions (which would not pass
our mail-gateway anyways :)

testing this is best done by applying the patches and running
`make update-kam`

With using kam_sa-channels_mcgrail_com.cf to include all files in the
ruleset the adaptation of the local.cf template (pmg-api patch 1/1) would
need a versioned dependeny bump on proxmox-spamassassin

In my tests spamassassin (pmg-smtp-filter) quite happily ignored the
missing /usr/share/spamassassin-extra/KAM.cf file - so a Breaks in the
other direction should not be needed.

proxmox-spamassassin:
Stoiko Ivanov (2):
  kam-rules: ship full ruleset not only KAM.cf
  buildsys: update outdated docs on updating rulesets

 Makefile | 41 +++++++++++++++++------------------------
 1 file changed, 17 insertions(+), 24 deletions(-)

pmg-api:
Stoiko Ivanov (1):
  templates: adapt to new path for KAM rules in proxmox-spamassassin

 src/templates/local.cf.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.30.2





             reply	other threads:[~2023-03-24 12:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-24 12:46 Stoiko Ivanov [this message]
2023-03-24 12:46 ` [pmg-devel] [PATCH spamassassin 1/2] kam-rules: ship full ruleset not only KAM.cf Stoiko Ivanov
2023-03-24 12:46 ` [pmg-devel] [PATCH spamassassin 2/2] buildsys: update outdated docs on updating rulesets Stoiko Ivanov
2023-03-24 12:46 ` [pmg-devel] [PATCH pmg-api 1/1] templates: adapt to new path for KAM rules in proxmox-spamassassin Stoiko Ivanov
2023-03-26 16:11 ` [pmg-devel] applied-series: [PATCH spamassassin/pmg-api ] ship complete KAM ruleset Thomas Lamprecht
2023-03-27  8:43   ` Stoiko Ivanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230324124655.39567-1-s.ivanov@proxmox.com \
    --to=s.ivanov@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal