Re: [pmg-devel] [PATCH pmg-{api, gui, docs} 0/3] fix #2437: Add TLS inbound policy for sender domains

[Christoph Heiss <c.heiss@proxmox.com>]

Thanks for the review on the whole series!

On Thu, Mar 16, 2023 at 01:28:42PM +0100, Stoiko Ivanov wrote:
> Thanks for tackling this!!
>
> Works as advertised in general - so I think the approach is fine
>
> One thing that seems odd to me (and sadly I don't have a good and short
> answer) is that it's not a policy we're setting - it's a list of domains,
> for which the singular policy (in this context) is that we accept mails
> from them only via tls...
I'm bad at naming as per usual :^) I agree that 'policy' might be the
wrong word for that ..

>
> Inbound TLS Domains ? (at least mentions TLS, and explicitly mentioning
> domains might be hint enough that you cannot enter an IP (or network)
> there)
> Reject Plaintext Domains? (probably only appeals to users who know
> `postconf(5)` by heart)
From the two suggestions above I'd IMHO go with 'Inbound TLS Domains' -
it mostly says what it does on the tin and is probably one of the better
options in general.
The latter - as you say - leans very much on postfix nomenclature and
might be unclear to (some) users.

If that's okay with you I'll rename it for v2 and than see how it looks.

>
> some comments inline (some as reply to the individual patches):
> On Thu,  9 Mar 2023 11:18:43 +0100
> Christoph Heiss <c.heiss@proxmox.com> wrote:
>
> > [..]
> > The documentation changes are quite terse, maybe I should expand a bit
> > more on that topic? (Although the TLS destination policy is only lightly
> > documented as well, as far as I could see.)
> I personally am fine with terse documentation - however I always try to
> refer to the authoritative source - in this case the relevant postfix
> config parameter ([1]) - that way users who want to get more details
> actually see what's going on under the hood).
> You could rephrase the docs to mention that it sets
> reject_plaintext_session for those domains during MAIL FROM)
Ack, I'll add a link to the postfix config parameter and mention that it
sets `reject_plaintext_session`.

>
>
> >
> > Testing
> > -------
> > [..]
> I use swaks (apt installable) quite extensively for such things - short of
> smtputf8 support it should cover most use-cases - but thanks for the tip
> with curl being able to speak smtp as well :)
Haven't heard of or used swaks before, looks very useful - thanks for the
tip as well!

curl speaks ~every protocol that exists, so it was simply the first tool
that came to my mind :)

>
> >
> >   450 4.7.1 Session encryption is required
> >
> > When additionally adding the `--ssl-reqd` option to curl (instructing it
> > to require a TLS-encrypted session), the above command will succeed.
> >
> > (Also tested it with a domain not on the list, checking that no
> > regressions are introduced.)
> >
> > [0] https://bugzilla.proxmox.com/show_bug.cgi?id=2437
> > [1] http://www.postfix.org/postconf.5.html#reject_plaintext_session
> >
> > ---
> > pmg-api:
> >
> > Christoph Heiss (1):
> >       fix #2437: config: Add inbound TLS policy option
> >
> >  src/Makefile                     |   1 +
> >  src/PMG/API2/Config.pm           |   7 +++
> >  src/PMG/API2/InboundTLSPolicy.pm | 127 +++++++++++++++++++++++++++++++++++++++
> >  src/PMG/Config.pm                |  56 +++++++++++++++++
> >  src/templates/main.cf.in         |   1 +
> >  5 files changed, 192 insertions(+)
> >
> > pmg-gui:
> >
> > Christoph Heiss (1):
> >       fix #2437: proxy: Add 'TLS Inbound Policy' panel
> >
> >  js/MailProxyTLSInboundPolicy.js | 93 +++++++++++++++++++++++++++++++++++++++++
> >  js/MailProxyTLSPanel.js         |  8 +++-
> >  js/Makefile                     |  1 +
> >  3 files changed, 101 insertions(+), 1 deletion(-)
> >
> > pmg-docs:
> >
> > Christoph Heiss (1):
> >       pmgconfig: Explain new TLS inbound policy configuration
> >
> >  pmgconfig.adoc | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > --
> > 2.39.2
> >
> >
> >
> > _______________________________________________
> > pmg-devel mailing list
> > pmg-devel@lists.proxmox.com
> > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
> >
> >
>