From: Leo Nunner <l.nunner@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] [PATCH pmg-api] fix #4536: parse original filenames from gzip files
Date: Fri, 3 Mar 2023 11:04:56 +0100 [thread overview]
Message-ID: <20230303100456.51670-1-l.nunner@proxmox.com> (raw)
GZIP provides the possiblity to store the original filename in the
optional FNAME header field, which we can use for 'Match Archive
Filename' rules.
IO::Uncompress::Gunzip is explicitly recommended for this purpose by the
documentation on Compress::Zlib, so an additional imnport was
introduced here.
Signed-off-by: Leo Nunner <l.nunner@proxmox.com>
---
src/PMG/Unpack.pm | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/src/PMG/Unpack.pm b/src/PMG/Unpack.pm
index d4fe454..f79ed3f 100755
--- a/src/PMG/Unpack.pm
+++ b/src/PMG/Unpack.pm
@@ -7,6 +7,7 @@ use IO::Select;
use Xdgmime;
use Compress::Zlib qw(gzopen);
use Compress::Bzip2 qw(bzopen);
+use IO::Uncompress::Gunzip;
use File::Path;
use File::Temp qw(tempdir);
use File::Basename;
@@ -298,6 +299,13 @@ sub uncompress_file {
$maxsize = min2 ($maxsize, $filesize * $self->{maxratio});
}
+ if($app eq 'guzip' && (my $z = IO::Uncompress::Gunzip->new($filename))) {
+ # the name (FNAME) field is optional in GZIP archives, so we won't
+ # always have a value here
+ my $header = $z->getHeaderInfo();
+ $newname = $header->{Name} if $header->{Name};
+ }
+
$self->add_glob_mime_type ($newname);
my $outfd;
--
2.30.2
next reply other threads:[~2023-03-03 10:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 10:04 Leo Nunner [this message]
2023-03-03 11:43 ` Stoiko Ivanov
2023-03-03 12:18 ` Leo Nunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230303100456.51670-1-l.nunner@proxmox.com \
--to=l.nunner@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox