[pmg-devel] [PATCH pmg-api v2] rulecache: sort rules additionally by id

[pmg-devel] [PATCH pmg-api v2] rulecache: sort rules additionally by id

[Stoiko Ivanov]

When more rules have the same priority currently their order is not
stable - postgres returns them in a stable way, based on their last
changetime - e.g. disabling and reenabling a rule puts it in the front
of evaluation. Sortin by id (the primary key) in addition should make
rule evaluation robust to such updates

While there is no guarantee of ordering (within the same priority)
unexpected changes in which rule fires can cause confusion (at least
it confused me quite a bit).

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
v1->v2:
* changed the ordering so that the sorting by priority did not get reversed
  huge thx to Dominik for testing and noticing! [0]
[0] https://www.postgresql.org/docs/current/queries-order.html

 src/PMG/RuleCache.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PMG/RuleCache.pm b/src/PMG/RuleCache.pm
index d35e9c1..b8690ea 100644
--- a/src/PMG/RuleCache.pm
+++ b/src/PMG/RuleCache.pm
@@ -37,7 +37,7 @@ sub new {
 	my $sth = $dbh->prepare(
 	    "SELECT ID, Name, Priority, Active, Direction FROM Rule " .
 	    "where Active > 0 " .
-	    "ORDER BY Priority DESC");
+	    "ORDER BY Priority DESC, ID DESC");
 
 	$sth->execute();
 
-- 
2.30.2

[pmg-devel] applied: [PATCH pmg-api v2] rulecache: sort rules additionally by id

[Dominik Csapak]

applied, thanks