From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] [PATCH pmg-api 0/2] fix deprecation warning for user blocklist hits
Date: Mon, 28 Nov 2022 19:17:27 +0100 [thread overview]
Message-ID: <20221128181729.63076-1-s.ivanov@proxmox.com> (raw)
the 2 patches address quite different issues, both becoming visible when a
mail is blocked/quarantined due to being on the receivers blocklist:
* currently we use the description from SA for 'USER_IN_BLACKLIST', which
includes since a while a deprecation warning (it's been replaced by
USER_IN_BLOCKLIST, and afaict the old version will be dropped with
SpamAssassin 4.0 soon). However PMG's SA rule only shares the name with
the one from upstream SA (in the sense that our source of addresses is
the database and not the SA-config), so we should make sure that the
description is consistent
* We should also rethink/adapt our use of racially charged terms (and try
to be consistent with SpamAssassin upstream in our choices) - I plan on
addressing this once SpamAssassin 4.0 is released (patch 2/2 is only a
small part and only touches the user/admin visible parts for the user
blocklists)
For now the issue is a cosmetic one, and both approaches would address the
spurious DEPRECATED in the spaminfo widget in the GUI (although patch 1/2
moves code around that 2/2 touches)
Stoiko Ivanov (2):
user-bl: use custom description of USER_IN_BLACKLIST consistently
user accesslists: reword logging and hits for SA 4.0
src/PMG/RuleDB/Spam.pm | 10 +++++-----
src/PMG/Utils.pm | 6 ++++++
2 files changed, 11 insertions(+), 5 deletions(-)
--
2.30.2
next reply other threads:[~2022-11-28 18:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 18:17 Stoiko Ivanov [this message]
2022-11-28 18:17 ` [pmg-devel] [PATCH pmg-api 1/2] user-bl: use custom description of USER_IN_BLACKLIST consistently Stoiko Ivanov
2022-11-28 18:17 ` [pmg-devel] [PATCH pmg-api 2/2] user accesslists: reword logging and hits for SA 4.0 Stoiko Ivanov
2022-11-29 15:07 ` [pmg-devel] applied-series: [PATCH pmg-api 0/2] fix deprecation warning for user blocklist hits Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221128181729.63076-1-s.ivanov@proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox