[pmg-devel] [PATCH pmg-gui 2/2] AttachmentGrid: filter attachment with content-disposition by default

[Dominik Csapak <d.csapak@proxmox.com>]

normally, attachments are given the 'content-disposition: attachment'
mime attribute, so we use that to filter the attachements

but since we're dealing with spam & virus mails here, and that field
is client controlled, give the user a way to toggle the remaining parts
of the mail too.

added the checkbox in the header part, but that made it necessary to
manually implement the expand/collapse toggle (since the tools are on
the wrong side of the default toggle)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 js/AttachmentGrid.js | 61 ++++++++++++++++++++++++++++++++++++--------
 1 file changed, 50 insertions(+), 11 deletions(-)

diff --git a/js/AttachmentGrid.js b/js/AttachmentGrid.js
index 3187a58..b6d8b4a 100644
--- a/js/AttachmentGrid.js
+++ b/js/AttachmentGrid.js
@@ -11,16 +11,52 @@ Ext.define('PMG.grid.AttachmentGrid', {
     minHeight: 50,
     maxHeight: 250,
     scrollable: true,
+    collapsed: true,
 
-    collapsible: true,
-    titleCollapse: true,
+    tools: [
+	{
+	    xtype: 'checkbox',
+	    boxLabel: gettext('show all parts'),
+	    boxLabelAlgign: 'before',
+	    listeners: {
+		change: function(cb, value) {
+		    let grid = this.up('pmgAttachmentGrid');
+		    let store = grid.getStore();
+		    store.clearFilter();
+		    if (!value) {
+			store.filter({
+			    property: 'content-disposition',
+			    value: 'attachment',
+			});
+		    }
+		},
+	    },
+	},
+	{
+	    type: 'down',
+	    handler: function() {
+		let me = this;
+		let type = me.type === 'up' ? 'down' : 'up';
+		me.up('pmgAttachmentGrid').toggleCollapse();
+		me.setType(type);
+	    },
+	},
+    ],
+
+    header: {
+	padding: '6 10 6 10', // make same height as normal panel
+    },
 
     store: {
 	autoDestroy: true,
-	fields: ['name', 'content-type', 'size'],
+	fields: ['name', 'content-type', 'size', 'content-disposition'],
 	proxy: {
 	    type: 'proxmox',
 	},
+	filters: {
+	    property: 'content-disposition',
+	    value: 'attachment',
+	},
     },
 
     controller: {
@@ -35,8 +71,15 @@ Ext.define('PMG.grid.AttachmentGrid', {
 		view.updateTitleStats(-1);
 		return;
 	    }
-	    let totalSize = records.reduce((sum, { data }) => sum + data.size, 0);
-	    view.updateTitleStats(records.length, totalSize);
+	    let count = 0;
+	    let totalSize = records.reduce((sum, { data }) => {
+		if (data['content-disposition'] === 'attachment') {
+		    count++;
+		    return sum + data.size;
+		}
+		return sum;
+	    }, 0);
+	    view.updateTitleStats(count, totalSize);
 	},
     },
 
@@ -46,14 +89,10 @@ Ext.define('PMG.grid.AttachmentGrid', {
 	if (count > 0) {
 	    title = Ext.String.format(gettext('{0} Attachments'), count);
 	    title += ` (${Proxmox.Utils.format_size(totalSize)})`;
-	    if (me.collapsible) {
-		me.expand();
-	    }
+	    me.expand();
 	} else {
 	    title = gettext('No Attachments');
-	    if (me.collapsible) {
-		me.collapse();
-	    }
+	    me.collapse();
 	}
 	me.setTitle(title);
     },
-- 
2.30.2