* [pmg-devel] applied: [PATCH] spam quarantine controller: fix args when calling the parent multiSelect
@ 2022-11-07 12:18 Thomas Lamprecht
0 siblings, 0 replies; only message in thread
From: Thomas Lamprecht @ 2022-11-07 12:18 UTC (permalink / raw)
To: pmg-devel
arguments needs to be an array, often we call with all of ours, iow.
using `arguments` which itself is an array already.
Both, manual construction and just a passing `arguments` have their
advantage and disadvantage, e.g., if either the inheriting or
bequesting class becomes more specialized, but most of the time using
`arguments` is more future proof.
Fixes: e66c888 ("quarantine: refactor spamquarantine controller")
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---
avoids an spurious undefined when selecting multiple emails.
js/SpamQuarantine.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/js/SpamQuarantine.js b/js/SpamQuarantine.js
index 388fc02..7487c8f 100644
--- a/js/SpamQuarantine.js
+++ b/js/SpamQuarantine.js
@@ -51,7 +51,7 @@ Ext.define('PMG.SpamQuarantineController', {
spam.setDisabled(true);
spam.setPressed(false);
me.lookupReference('spaminfo').setVisible(false);
- me.callParent(selection);
+ me.callParent(arguments);
},
toggleSpamInfo: function(btn) {
--
2.30.2
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-11-07 12:19 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-07 12:18 [pmg-devel] applied: [PATCH] spam quarantine controller: fix args when calling the parent multiSelect Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox