From: Dominik Csapak <d.csapak@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] [PATCH pmg-gui 4/5] quarantine: improve borders for docked items
Date: Fri, 4 Nov 2022 16:04:24 +0100 [thread overview]
Message-ID: <20221104150425.124194-6-d.csapak@proxmox.com> (raw)
In-Reply-To: <20221104150425.124194-1-d.csapak@proxmox.com>
one cannot set the different borders seperately in panels/grids and
docked items don't have a bottom border in extjs, but we want to remove
all borders except the ones between the toolbar and the grids/content
below that.
to achieve that, set a custom 'border-bottom-width' with '!important'
(extjs has a rule with !important as well) for the toolbar, and
everywhere else remove the border.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
js/SpamQuarantine.js | 8 +++++++-
js/VirusQuarantine.js | 6 ++++++
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/js/SpamQuarantine.js b/js/SpamQuarantine.js
index d3afcc5..2cdca0d 100644
--- a/js/SpamQuarantine.js
+++ b/js/SpamQuarantine.js
@@ -204,6 +204,11 @@ Ext.define('PMG.SpamQuarantine', {
{
xtype: 'toolbar',
dock: 'top',
+ style: {
+ // docked items have set the bottom with to 0px with '! important'
+ // but we still want one here, so we can remove the borders of the grids
+ 'border-bottom-width': '1px ! important',
+ },
items: [
{
xtype: 'button',
@@ -270,8 +275,8 @@ Ext.define('PMG.SpamQuarantine', {
},
{
xtype: 'pmgSpamInfoGrid',
- border: false,
reference: 'spaminfo',
+ border: false,
},
{
xtype: 'pmgAttachmentGrid',
@@ -286,6 +291,7 @@ Ext.define('PMG.SpamQuarantine', {
xtype: 'pmgMailInfo',
hidden: true,
reference: 'mailinfo',
+ border: false,
},
],
},
diff --git a/js/VirusQuarantine.js b/js/VirusQuarantine.js
index 8580e7a..a92ba28 100644
--- a/js/VirusQuarantine.js
+++ b/js/VirusQuarantine.js
@@ -106,6 +106,11 @@ Ext.define('PMG.VirusQuarantine', {
{
xtype: 'toolbar',
dock: 'top',
+ style: {
+ // docked items have set the bottom with to 0px with '! important'
+ // but we still want one here, so we can remove the borders of the grids
+ 'border-bottom-width': '1px ! important',
+ },
items: [
{
xtype: 'button',
@@ -163,6 +168,7 @@ Ext.define('PMG.VirusQuarantine', {
xtype: 'pmgMailInfo',
hidden: true,
reference: 'mailinfo',
+ border: false,
},
],
},
--
2.30.2
next prev parent reply other threads:[~2022-11-04 15:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 15:04 [pmg-devel] [PATCH pmg-api/pmg-gui] improvements to the quarantine interface Dominik Csapak
2022-11-04 15:04 ` [pmg-devel] [PATCH pmg-api 1/1] api/quarantine: allow 'listattachments' for quarantine users Dominik Csapak
2022-11-07 8:47 ` [pmg-devel] applied: " Thomas Lamprecht
2022-11-04 15:04 ` [pmg-devel] [PATCH pmg-gui 1/5] simply quarantine controllers a bit Dominik Csapak
2022-11-07 8:47 ` [pmg-devel] applied: " Thomas Lamprecht
2022-11-04 15:04 ` [pmg-devel] [PATCH pmg-gui 2/5] quarantines: add attachment grid to spam and virus quarantine Dominik Csapak
2022-11-07 12:21 ` [pmg-devel] applied: " Thomas Lamprecht
2022-11-04 15:04 ` [pmg-devel] [PATCH pmg-gui 3/5] fix #4238: SpamInfoGrid: enable sorting & add colors for spam score Dominik Csapak
2022-11-07 9:56 ` [pmg-devel] applied: " Thomas Lamprecht
2022-11-04 15:04 ` Dominik Csapak [this message]
2022-11-07 9:57 ` [pmg-devel] applied: [PATCH pmg-gui 4/5] quarantine: improve borders for docked items Thomas Lamprecht
2022-11-04 15:04 ` [pmg-devel] [PATCH pmg-gui 5/5] fix #2533: quarantine: add overflowHandler to the preview panel Dominik Csapak
2022-11-07 9:57 ` [pmg-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221104150425.124194-6-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox