From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Fabian Ebner <f.ebner@proxmox.com>
Cc: pve-devel@lists.proxmox.com, pmg-devel@lists.proxmox.com
Subject: [pmg-devel] applied-series: [PATCH pmg-api 1/2] api: get group snapshots: take backup-id into account
Date: Fri, 4 Nov 2022 14:28:12 +0100 [thread overview]
Message-ID: <20221104132812.l4kycfg7l7eytjfp@casey.proxmox.com> (raw)
In-Reply-To: <20220720105948.291740-7-f.ebner@proxmox.com>
applied & bumped common dep accordingly
On Wed, Jul 20, 2022 at 12:59:46PM +0200, Fabian Ebner wrote:
> instead of assuming that the requested ID is the same as the node in
> the API path. This endpoint is not currently used in the UI AFAICS.
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> src/PMG/API2/PBS/Job.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/PMG/API2/PBS/Job.pm b/src/PMG/API2/PBS/Job.pm
> index 3f775d6..be9cc06 100644
> --- a/src/PMG/API2/PBS/Job.pm
> +++ b/src/PMG/API2/PBS/Job.pm
> @@ -209,7 +209,7 @@ __PACKAGE__->register_method ({
> code => sub {
> my ($param) = @_;
>
> - return get_snapshots($param->{remote}, "host/$param->{node}");
> + return get_snapshots($param->{remote}, "host/$param->{'backup-id'}");
> }});
>
> __PACKAGE__->register_method ({
> --
> 2.30.2
next prev parent reply other threads:[~2022-11-04 13:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 10:59 [pmg-devel] [PATCH-SERIES pve-common/pmg-api/pve-storage] pbs client: rework namespace usage and minor fixes Fabian Ebner
2022-07-20 10:59 ` [pmg-devel] [PATCH pve-common 1/5] pbs client: delete password: return success for non-existent file Fabian Ebner
2022-07-20 10:59 ` [pmg-devel] [PATCH pve-common 2/5] pbs client: forget snapshot: suppress output Fabian Ebner
2022-07-20 10:59 ` [pmg-devel] [PATCH pve-common 3/5] pbs client: default to configured namespace for non-namespaced parameters Fabian Ebner
2022-11-04 8:44 ` Fiona Ebner
2022-07-20 10:59 ` [pmg-devel] [RFC/PATCH pve-common 4/5] pbs client: deprecate namespaced parameters Fabian Ebner
2022-07-20 10:59 ` [pmg-devel] [RFC/PATCH pve-common 5/5] pbs client: backup fs tree: drop namespace parameter Fabian Ebner
2022-07-22 10:53 ` [pmg-devel] [pve-devel] " Wolfgang Bumiller
2022-07-25 8:04 ` Fiona Ebner
2022-11-04 13:16 ` [pmg-devel] applied-series: " Wolfgang Bumiller
2022-07-20 10:59 ` [pmg-devel] [PATCH pmg-api 1/2] api: get group snapshots: take backup-id into account Fabian Ebner
2022-11-04 13:28 ` Wolfgang Bumiller [this message]
2022-07-20 10:59 ` [pmg-devel] [RFC/PATCH pmg-api 2/2] api: pbs: don't use namespaced parameters Fabian Ebner
2022-07-20 10:59 ` [pmg-devel] [RFC/PATCH pve-storage 1/1] api: pbs: file restore: " Fabian Ebner
2022-11-04 13:17 ` [pmg-devel] applied: " Wolfgang Bumiller
2022-10-04 8:08 ` [pmg-devel] [PATCH-SERIES pve-common/pmg-api/pve-storage] pbs client: rework namespace usage and minor fixes Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221104132812.l4kycfg7l7eytjfp@casey.proxmox.com \
--to=w.bumiller@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox