From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Fabian Ebner <f.ebner@proxmox.com>
Cc: pve-devel@lists.proxmox.com, pmg-devel@lists.proxmox.com
Subject: [pmg-devel] applied: [RFC/PATCH pve-storage 1/1] api: pbs: file restore: don't use namespaced parameters
Date: Fri, 4 Nov 2022 14:17:17 +0100 [thread overview]
Message-ID: <20221104131717.5z24gkavhz5wntvc@casey.proxmox.com> (raw)
In-Reply-To: <20220720105948.291740-9-f.ebner@proxmox.com>
applied & dumped dependency accordingly
On Wed, Jul 20, 2022 at 12:59:48PM +0200, Fabian Ebner wrote:
> Instead, rely on PBSClient to set namespace according to the initial
> configuration.
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>
> Dependency bump for new libpve-common-perl needed.
>
> PVE/API2/Storage/FileRestore.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/PVE/API2/Storage/FileRestore.pm b/PVE/API2/Storage/FileRestore.pm
> index 5630f52..ccc56e5 100644
> --- a/PVE/API2/Storage/FileRestore.pm
> +++ b/PVE/API2/Storage/FileRestore.pm
> @@ -119,7 +119,7 @@ __PACKAGE__->register_method ({
> my (undef, $snap) = PVE::Storage::parse_volname($cfg, $volid);
>
> my $client = PVE::PBSClient->new($scfg, $storeid);
> - my $ret = $client->file_restore_list([$scfg->{namespace}, $snap], $path, $base64);
> + my $ret = $client->file_restore_list($snap, $path, $base64);
>
> # 'leaf' is a proper JSON boolean, map to perl-y bool
> # TODO: make PBSClient decode all bools always as 1/0?
> @@ -188,7 +188,7 @@ __PACKAGE__->register_method ({
> $rpcenv->fork_worker('pbs-download', undef, $user, sub {
> my $name = decode_base64($path);
> print "Starting download of file: $name\n";
> - $client->file_restore_extract($fifo, [$scfg->{namespace}, $snap], $path, 1);
> + $client->file_restore_extract($fifo, $snap, $path, 1);
> });
>
> my $ret = {
> --
> 2.30.2
next prev parent reply other threads:[~2022-11-04 13:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 10:59 [pmg-devel] [PATCH-SERIES pve-common/pmg-api/pve-storage] pbs client: rework namespace usage and minor fixes Fabian Ebner
2022-07-20 10:59 ` [pmg-devel] [PATCH pve-common 1/5] pbs client: delete password: return success for non-existent file Fabian Ebner
2022-07-20 10:59 ` [pmg-devel] [PATCH pve-common 2/5] pbs client: forget snapshot: suppress output Fabian Ebner
2022-07-20 10:59 ` [pmg-devel] [PATCH pve-common 3/5] pbs client: default to configured namespace for non-namespaced parameters Fabian Ebner
2022-11-04 8:44 ` Fiona Ebner
2022-07-20 10:59 ` [pmg-devel] [RFC/PATCH pve-common 4/5] pbs client: deprecate namespaced parameters Fabian Ebner
2022-07-20 10:59 ` [pmg-devel] [RFC/PATCH pve-common 5/5] pbs client: backup fs tree: drop namespace parameter Fabian Ebner
2022-07-22 10:53 ` [pmg-devel] [pve-devel] " Wolfgang Bumiller
2022-07-25 8:04 ` Fiona Ebner
2022-11-04 13:16 ` [pmg-devel] applied-series: " Wolfgang Bumiller
2022-07-20 10:59 ` [pmg-devel] [PATCH pmg-api 1/2] api: get group snapshots: take backup-id into account Fabian Ebner
2022-11-04 13:28 ` [pmg-devel] applied-series: " Wolfgang Bumiller
2022-07-20 10:59 ` [pmg-devel] [RFC/PATCH pmg-api 2/2] api: pbs: don't use namespaced parameters Fabian Ebner
2022-07-20 10:59 ` [pmg-devel] [RFC/PATCH pve-storage 1/1] api: pbs: file restore: " Fabian Ebner
2022-11-04 13:17 ` Wolfgang Bumiller [this message]
2022-10-04 8:08 ` [pmg-devel] [PATCH-SERIES pve-common/pmg-api/pve-storage] pbs client: rework namespace usage and minor fixes Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221104131717.5z24gkavhz5wntvc@casey.proxmox.com \
--to=w.bumiller@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox