* [pmg-devel] [PATCH pmg-api v2] pmg-daily: avoid short-circuting update of local channels
@ 2022-07-13 9:09 Stoiko Ivanov
2022-07-13 9:13 ` [pmg-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Stoiko Ivanov @ 2022-07-13 9:09 UTC (permalink / raw)
To: pmg-devel
by using ||= directly with the actual update call, it does not get
run, if `sa-update` already returned that a restart is needed.
reported in our community forum:
https://forum.proxmox.com/threads/.112112/
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
v1->v2:
* dropped the temporary variable in favor of a post-if (more in line
with our remaining code - and actually prettier imho) - thx@Thomas
for the suggestion!
src/bin/pmg-daily | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/bin/pmg-daily b/src/bin/pmg-daily
index b06515c..d67a88a 100755
--- a/src/bin/pmg-daily
+++ b/src/bin/pmg-daily
@@ -85,7 +85,7 @@ if (system('sa-update') == 0) {
}
eval {
- $restart_filter ||= PMG::Utils::update_local_spamassassin_channels(0);
+ $restart_filter = 1 if PMG::Utils::update_local_spamassassin_channels(0);
};
syslog('err', "$@") if $@;
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pmg-devel] applied: [PATCH pmg-api v2] pmg-daily: avoid short-circuting update of local channels
2022-07-13 9:09 [pmg-devel] [PATCH pmg-api v2] pmg-daily: avoid short-circuting update of local channels Stoiko Ivanov
@ 2022-07-13 9:13 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2022-07-13 9:13 UTC (permalink / raw)
To: Stoiko Ivanov, pmg-devel
Am 13/07/2022 um 11:09 schrieb Stoiko Ivanov:
> by using ||= directly with the actual update call, it does not get
> run, if `sa-update` already returned that a restart is needed.
>
> reported in our community forum:
> https://forum.proxmox.com/threads/.112112/
>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> v1->v2:
> * dropped the temporary variable in favor of a post-if (more in line
> with our remaining code - and actually prettier imho) - thx@Thomas
> for the suggestion!
> src/bin/pmg-daily | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-13 9:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-13 9:09 [pmg-devel] [PATCH pmg-api v2] pmg-daily: avoid short-circuting update of local channels Stoiko Ivanov
2022-07-13 9:13 ` [pmg-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox