From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] [PATCH pmg-api v2] pmg-daily: avoid short-circuting update of local channels
Date: Wed, 13 Jul 2022 11:09:35 +0200 [thread overview]
Message-ID: <20220713090935.4725-1-s.ivanov@proxmox.com> (raw)
by using ||= directly with the actual update call, it does not get
run, if `sa-update` already returned that a restart is needed.
reported in our community forum:
https://forum.proxmox.com/threads/.112112/
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
v1->v2:
* dropped the temporary variable in favor of a post-if (more in line
with our remaining code - and actually prettier imho) - thx@Thomas
for the suggestion!
src/bin/pmg-daily | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/bin/pmg-daily b/src/bin/pmg-daily
index b06515c..d67a88a 100755
--- a/src/bin/pmg-daily
+++ b/src/bin/pmg-daily
@@ -85,7 +85,7 @@ if (system('sa-update') == 0) {
}
eval {
- $restart_filter ||= PMG::Utils::update_local_spamassassin_channels(0);
+ $restart_filter = 1 if PMG::Utils::update_local_spamassassin_channels(0);
};
syslog('err', "$@") if $@;
--
2.30.2
next reply other threads:[~2022-07-13 9:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 9:09 Stoiko Ivanov [this message]
2022-07-13 9:13 ` [pmg-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220713090935.4725-1-s.ivanov@proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox