From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: Wolfgang Bumiller <w.bumiller@proxmox.com>
Cc: pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH log-tracker] drop 'time' dependency
Date: Mon, 14 Feb 2022 19:09:33 +0100 [thread overview]
Message-ID: <20220214190933.22d928d5@rosa.proxmox.com> (raw)
In-Reply-To: <20220104135723.111515-1-w.bumiller@proxmox.com>
applied - with the FIXME comment removed and my R-b, T-b tags added
huge thanks again!
On Tue, 4 Jan 2022 14:57:23 +0100
Wolfgang Bumiller <w.bumiller@proxmox.com> wrote:
> We're using a very old version of it and the functions we
> actually use are available in glibc anyway.
>
> The only difference I found was that the result of
> glibc's `strptime()`'s `%s` does *not* want an additional
> `.to_local()` call anymore...
>
> ... which was weird anyway.
>
> As a minor optimization I pass the format string as `&CStr`
> to avoid the memcpy.
>
> (The CString::new() call in `strptime()` only happens during
> parameter parsing)
>
> Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
> ---
> Cargo.toml | 1 -
> src/main.rs | 75 ++++++++---------------
> src/time.rs | 169 ++++++++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 194 insertions(+), 51 deletions(-)
> create mode 100644 src/time.rs
>
> .. snip ...
prev parent reply other threads:[~2022-02-14 18:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 13:57 Wolfgang Bumiller
2022-01-05 19:01 ` Stoiko Ivanov
2022-02-14 18:09 ` Stoiko Ivanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220214190933.22d928d5@rosa.proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox