From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>
Cc: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] applied-series: [PATCH pmg-api v2 0/2] fix #2795 - add DSN support
Date: Fri, 26 Nov 2021 12:02:44 +0100 [thread overview]
Message-ID: <20211126120244.6384e756@rosa.proxmox.com> (raw)
In-Reply-To: <24a5a33e-20eb-5290-a808-4361cf77702c@proxmox.com>
On Fri, 26 Nov 2021 11:10:45 +0100
Dominik Csapak <d.csapak@proxmox.com> wrote:
> LGTM
>
> Tested with after/before queue with and withoud dsn
> (got a dsn reply everytime i expected it)
>
> Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
> Tested-by: Dominik Csapak <d.csapak@proxmox.com>
Huge thanks again - applied with added R-b and T-b
>
> On 11/25/21 13:03, Stoiko Ivanov wrote:
> > v1->v2:
> > * incorporated Dominik's feedback - huge thanks!!
> > * all parameters we don't care about are ignored (as before)
> > * the options are not transformed into lowercase unconditionally anymore
> > (they contain mail-addresses, and mail-ids - which are not case-insensitive)
> > * split up the patch into 2 commits - since the regexes for the MAIL and
> > RCPT commands is more sensitive than I expected:
> > ** read up on allowed characters in local-parts - tried extending the regex
> > to parse mailboxes more correctly - failed at that
> > ** decided it's ok to not allow '>' in localparts (we did not do so before)
> > ** did quite a bit more testing thanks to that
> >
> >
> > Stoiko Ivanov (2):
> > partially fix #2795: allow for '>' in smtp parameters
> > fix #2795: add support for DSN
> >
> > src/PMG/RuleDB/Accept.pm | 2 +-
> > src/PMG/RuleDB/BCC.pm | 6 +++++-
> > src/PMG/SMTP.pm | 27 ++++++++++++++++++++++-----
> > src/PMG/Utils.pm | 19 ++++++++++++++++---
> > src/bin/pmg-smtp-filter | 1 +
> > 5 files changed, 45 insertions(+), 10 deletions(-)
> >
>
>
prev parent reply other threads:[~2021-11-26 11:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 12:03 [pmg-devel] " Stoiko Ivanov
2021-11-25 12:03 ` [pmg-devel] [PATCH pmg-api v2 1/2] partially fix #2795: allow for '>' in smtp parameters Stoiko Ivanov
2021-11-25 12:03 ` [pmg-devel] [PATCH pmg-api v2 2/2] fix #2795: add support for DSN Stoiko Ivanov
2021-11-25 15:02 ` [pmg-devel] [PATCH pmg-api v2 0/2] fix #2795 - add DSN support Dominik Csapak
2021-11-26 10:10 ` Dominik Csapak
2021-11-26 10:40 ` Dominik Csapak
2021-11-26 11:57 ` Stoiko Ivanov
2021-11-26 11:02 ` Stoiko Ivanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211126120244.6384e756@rosa.proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox