public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] [PATCH pmg-gui 1/1] fix #3648: ldap config: do not send empty bindpw
Date: Wed, 27 Oct 2021 17:02:29 +0200	[thread overview]
Message-ID: <20211027150229.2610534-3-d.csapak@proxmox.com> (raw)
In-Reply-To: <20211027150229.2610534-1-d.csapak@proxmox.com>

so that we can reuse the saved one and the admin does not have
to enter the password on each config change (similar to PVE).

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 js/LDAPConfig.js | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/js/LDAPConfig.js b/js/LDAPConfig.js
index 19ec702..d7e4263 100644
--- a/js/LDAPConfig.js
+++ b/js/LDAPConfig.js
@@ -28,6 +28,11 @@ Ext.define('PMG.LDAPInputPanel', {
 	values.disable = values.enable ? 0 : 1;
 	delete values.enable;
 
+	// do not send empty password
+	if (values.bindpw === '') {
+	    delete values.bindpw;
+	}
+
 	return values;
     },
 
@@ -103,6 +108,7 @@ Ext.define('PMG.LDAPInputPanel', {
 		xtype: 'textfield',
 		inputType: 'password',
 		allowBlank: true,
+		emptyText: gettext('Unchanged'),
 		name: 'bindpw',
 		fieldLabel: gettext('Password'),
 	    },
-- 
2.30.2





  parent reply	other threads:[~2021-10-27 15:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-27 15:02 [pmg-devel] [PATCH pmg-api/pmg-gui] fix #3648: do not require bindpw on every update Dominik Csapak
2021-10-27 15:02 ` [pmg-devel] [PATCH pmg-api 1/1] api: ldap config: sync with the complete config Dominik Csapak
2021-10-27 15:02 ` Dominik Csapak [this message]
2021-10-28 20:23 ` [pmg-devel] applied-series: [PATCH pmg-api/pmg-gui] fix #3648: do not require bindpw on every update Stoiko Ivanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211027150229.2610534-3-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal