public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] [PATCH pmg-api 1/1] api: ldap config: sync with the complete config
Date: Wed, 27 Oct 2021 17:02:28 +0200	[thread overview]
Message-ID: <20211027150229.2610534-2-d.csapak@proxmox.com> (raw)
In-Reply-To: <20211027150229.2610534-1-d.csapak@proxmox.com>

use the complete config, not only the one from the parameters.
This is necessary to use the saved bindpw when it's not sent
via the api.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/PMG/API2/LDAP.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PMG/API2/LDAP.pm b/src/PMG/API2/LDAP.pm
index e07aae0..d2ee6a4 100644
--- a/src/PMG/API2/LDAP.pm
+++ b/src/PMG/API2/LDAP.pm
@@ -249,7 +249,7 @@ __PACKAGE__->register_method ({
 		$ids->{$profile}->{$p} = $config->{$p};
 	    }
 
-	    $forced_ldap_sync->($profile, $config)
+	    $forced_ldap_sync->($profile, $ids->{$profile})
 		if !$config->{disable};
 
 	    $cfg->write();
-- 
2.30.2





  reply	other threads:[~2021-10-27 15:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-27 15:02 [pmg-devel] [PATCH pmg-api/pmg-gui] fix #3648: do not require bindpw on every update Dominik Csapak
2021-10-27 15:02 ` Dominik Csapak [this message]
2021-10-27 15:02 ` [pmg-devel] [PATCH pmg-gui 1/1] fix #3648: ldap config: do not send empty bindpw Dominik Csapak
2021-10-28 20:23 ` [pmg-devel] applied-series: [PATCH pmg-api/pmg-gui] fix #3648: do not require bindpw on every update Stoiko Ivanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211027150229.2610534-2-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal