public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>
Cc: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] applied: [PATCH proxmox-acme-rs/pmg-rs] fix #3688: allow missing 'meta' property for acme directories
Date: Thu, 21 Oct 2021 13:24:40 +0200	[thread overview]
Message-ID: <20211021112440.ftabdueb4anz7lzc@olga.proxmox.com> (raw)
In-Reply-To: <20211021091044.2135964-1-d.csapak@proxmox.com>

applied both

On Thu, Oct 21, 2021 at 11:10:42AM +0200, Dominik Csapak wrote:
> like we already do in pve, also make the 'meta' property optional
> 
> NOTE: the code compiles, but the actual code path is untested, sending it with the
> intention to test on a patched pebble instance later (or maybe someone
> else can do that (@stoiko) ?)
> 
> proxmox-acme-rs:
> 
> Dominik Csapak (1):
>   directory: make meta object optional
> 
>  src/directory.rs | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> pmg-rs:
> 
> Dominik Csapak (1):
>   fix #3688: handle optional meta property of the directory
> 
>  src/acme.rs | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> -- 
> 2.30.2




      parent reply	other threads:[~2021-10-21 11:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-21  9:10 [pmg-devel] " Dominik Csapak
2021-10-21  9:10 ` [pmg-devel] [PATCH proxmox-acme-rs 1/1] directory: make meta object optional Dominik Csapak
2021-10-21  9:10 ` [pmg-devel] [PATCH pmg-rs 1/1] fix #3688: handle optional meta property of the directory Dominik Csapak
2021-10-21 11:24 ` Wolfgang Bumiller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211021112440.ftabdueb4anz7lzc@olga.proxmox.com \
    --to=w.bumiller@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal