public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: Oguz Bektas <o.bektas@proxmox.com>
Cc: pmg-devel@lists.proxmox.com, Thomas Lamprecht <t.lamprecht@proxmox.com>
Subject: [pmg-devel] applied: [PATCH v2 pmg-api] api: apt: use actual pmg-style permission for endpoint schema
Date: Fri, 3 Sep 2021 12:56:06 +0200	[thread overview]
Message-ID: <20210903125606.556881f6@rosa.proxmox.com> (raw)
In-Reply-To: <20210902084712.42924-1-o.bektas@proxmox.com>

huge thanks for the patch - tested and applied

On Thu,  2 Sep 2021 10:47:12 +0200
Oguz Bektas <o.bektas@proxmox.com> wrote:

> it wrongly uses the permission model from PVE, which caused the
> endpoints to be root-only as a side effect, since PMG API doesn't
> recognize the PVE-specific permissions.
> 
> fix those to allow PMG users with administrator role to add/delete
> repositories, and auditor role to view the repositories.
> 
> reported in a forum thread [0]
> 
> [0]:
> https://forum.proxmox.com/threads/no-apt-repo-information-for-non-root-on-the-web-gui.95217/
> 
> Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
> v1->v2:
> * update commit message and explain the root cause
> 
>  src/PMG/API2/APT.pm | 12 +++---------
>  1 file changed, 3 insertions(+), 9 deletions(-)
> 
> diff --git a/src/PMG/API2/APT.pm b/src/PMG/API2/APT.pm
> index 5e132c4..18bb992 100644
> --- a/src/PMG/API2/APT.pm
> +++ b/src/PMG/API2/APT.pm
> @@ -477,9 +477,7 @@ __PACKAGE__->register_method({
>      method => 'GET',
>      proxyto => 'node',
>      description => "Get APT repository information.",
> -    permissions => {
> -	check => ['perm', '/nodes/{node}', [ 'Sys.Audit' ]],
> -    },
> +    permissions => { check => [ 'admin', 'audit' ] },
>      parameters => {
>  	additionalProperties => 0,
>  	properties => {
> @@ -678,9 +676,7 @@ __PACKAGE__->register_method({
>      path => 'repositories',
>      method => 'PUT',
>      description => "Add a standard repository to the configuration",
> -    permissions => {
> -	check => ['perm', '/nodes/{node}', [ 'Sys.Modify' ]],
> -    },
> +    permissions => { check => [ 'admin' ] },
>      protected => 1,
>      proxyto => 'node',
>      parameters => {
> @@ -713,9 +709,7 @@ __PACKAGE__->register_method({
>      path => 'repositories',
>      method => 'POST',
>      description => "Change the properties of a repository. Currently only allows enabling/disabling.",
> -    permissions => {
> -	check => ['perm', '/nodes/{node}', [ 'Sys.Modify' ]],
> -    },
> +    permissions => { check => [ 'admin' ] },
>      protected => 1,
>      proxyto => 'node',
>      parameters => {





      reply	other threads:[~2021-09-03 10:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-02  8:47 [pmg-devel] " Oguz Bektas
2021-09-03 10:56 ` Stoiko Ivanov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210903125606.556881f6@rosa.proxmox.com \
    --to=s.ivanov@proxmox.com \
    --cc=o.bektas@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal