[pmg-devel] [PATCH proxmox-widget-toolkit 1/1] node: repos: add online help

[pmg-devel] [PATCH proxmox-widget-toolkit 1/1] node: repos: add online help

[Fabian Ebner]

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
 src/node/APTRepositories.js | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/node/APTRepositories.js b/src/node/APTRepositories.js
index c7222fc..9b74980 100644
--- a/src/node/APTRepositories.js
+++ b/src/node/APTRepositories.js
@@ -141,6 +141,7 @@ Ext.define('Proxmox.node.APTRepositoriesErrors', {
 Ext.define('Proxmox.node.APTRepositoriesGrid', {
     extend: 'Ext.grid.GridPanel',
     xtype: 'proxmoxNodeAPTRepositoriesGrid',
+    mixins: ['Proxmox.Mixin.CBind'],
 
     title: gettext('APT Repositories'),
 
@@ -162,6 +163,9 @@ Ext.define('Proxmox.node.APTRepositoriesGrid', {
 	    name: 'addRepo',
 	    disabled: true,
 	    repoInfo: undefined,
+	    cbind: {
+		onlineHelp: '{onlineHelp}',
+	    },
 	    handler: function(button, event, record) {
 		Proxmox.Utils.checked_command(() => {
 		    let me = this;
@@ -177,6 +181,7 @@ Ext.define('Proxmox.node.APTRepositoriesGrid', {
 			url: `/api2/extjs/nodes/${panel.nodename}/apt/repositories`,
 			method: 'PUT',
 			extraRequestParams: extraParams,
+			onlineHelp: me.onlineHelp,
 			listeners: {
 			    destroy: function() {
 				panel.reload();
@@ -410,6 +415,8 @@ Ext.define('Proxmox.node.APTRepositories', {
 
     digest: undefined,
 
+    onlineHelp: undefined,
+
     product: 'Proxmox VE', // default
 
     controller: {
@@ -575,6 +582,7 @@ Ext.define('Proxmox.node.APTRepositories', {
 	    flex: 1,
 	    cbind: {
 		nodename: '{nodename}',
+		onlineHelp: '{onlineHelp}',
 	    },
 	    majorUpgradeAllowed: false, // TODO get release information from an API call?
 	    listeners: {
-- 
2.30.2

[pmg-devel] [PATCH pmg-gui 1/1] server administration: repos: add online help

[Fabian Ebner]

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---

Depends on the previous patch to work correctly, but no hard
dependency.

 js/ServerAdministration.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/js/ServerAdministration.js b/js/ServerAdministration.js
index 332b03a..8cc50ab 100644
--- a/js/ServerAdministration.js
+++ b/js/ServerAdministration.js
@@ -57,6 +57,7 @@ Ext.define('PMG.ServerAdministration', {
 	    itemId: 'aptrepositories',
 	    nodename: 'localhost',
 	    product: 'Proxmox Mail Gateway',
+	    onlineHelp: 'pmg_package_repositories',
 	},
 	{
 	    xtype: 'proxmoxJournalView',
-- 
2.30.2

Re: [pmg-devel] [PATCH proxmox-widget-toolkit 1/1] node: repos: add online help

[Stoiko Ivanov]

Thanks for the patch!

applied both, and tried it out - works as advertised!

FWIW:
Reviewed-by: Stoiko Ivanov <s.ivanov@proxmox.com>
Tested-by: Stoiko Ivanov <s.ivanov@proxmox.com>

On Wed, 14 Jul 2021 14:55:47 +0200
Fabian Ebner <f.ebner@proxmox.com> wrote:

> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>  src/node/APTRepositories.js | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/src/node/APTRepositories.js b/src/node/APTRepositories.js
> index c7222fc..9b74980 100644
> --- a/src/node/APTRepositories.js
> +++ b/src/node/APTRepositories.js
> @@ -141,6 +141,7 @@ Ext.define('Proxmox.node.APTRepositoriesErrors', {
>  Ext.define('Proxmox.node.APTRepositoriesGrid', {
>      extend: 'Ext.grid.GridPanel',
>      xtype: 'proxmoxNodeAPTRepositoriesGrid',
> +    mixins: ['Proxmox.Mixin.CBind'],
>  
>      title: gettext('APT Repositories'),
>  
> @@ -162,6 +163,9 @@ Ext.define('Proxmox.node.APTRepositoriesGrid', {
>  	    name: 'addRepo',
>  	    disabled: true,
>  	    repoInfo: undefined,
> +	    cbind: {
> +		onlineHelp: '{onlineHelp}',
> +	    },
>  	    handler: function(button, event, record) {
>  		Proxmox.Utils.checked_command(() => {
>  		    let me = this;
> @@ -177,6 +181,7 @@ Ext.define('Proxmox.node.APTRepositoriesGrid', {
>  			url: `/api2/extjs/nodes/${panel.nodename}/apt/repositories`,
>  			method: 'PUT',
>  			extraRequestParams: extraParams,
> +			onlineHelp: me.onlineHelp,
>  			listeners: {
>  			    destroy: function() {
>  				panel.reload();
> @@ -410,6 +415,8 @@ Ext.define('Proxmox.node.APTRepositories', {
>  
>      digest: undefined,
>  
> +    onlineHelp: undefined,
> +
>      product: 'Proxmox VE', // default
>  
>      controller: {
> @@ -575,6 +582,7 @@ Ext.define('Proxmox.node.APTRepositories', {
>  	    flex: 1,
>  	    cbind: {
>  		nodename: '{nodename}',
> +		onlineHelp: '{onlineHelp}',
>  	    },
>  	    majorUpgradeAllowed: false, // TODO get release information from an API call?
>  	    listeners: {

[pmg-devel] applied: [PATCH proxmox-widget-toolkit 1/1] node: repos: add online help

[Thomas Lamprecht]

On 14.07.21 14:55, Fabian Ebner wrote:
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>  src/node/APTRepositories.js | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
>

applied, thanks!

[pmg-devel] applied: [PATCH pmg-gui 1/1] server administration: repos: add online help

[Thomas Lamprecht]

On 14.07.21 14:55, Fabian Ebner wrote:
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> 
> Depends on the previous patch to work correctly, but no hard
> dependency.
> 
>  js/ServerAdministration.js | 1 +
>  1 file changed, 1 insertion(+)
> 
>

applied, thanks!