Re: [pmg-devel] [PATCH proxmox-widget-toolkit 1/1] node: repos: add online help

[Stoiko Ivanov <s.ivanov@proxmox.com>]

Thanks for the patch!

applied both, and tried it out - works as advertised!

FWIW:
Reviewed-by: Stoiko Ivanov <s.ivanov@proxmox.com>
Tested-by: Stoiko Ivanov <s.ivanov@proxmox.com>

On Wed, 14 Jul 2021 14:55:47 +0200
Fabian Ebner <f.ebner@proxmox.com> wrote:

> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>  src/node/APTRepositories.js | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/src/node/APTRepositories.js b/src/node/APTRepositories.js
> index c7222fc..9b74980 100644
> --- a/src/node/APTRepositories.js
> +++ b/src/node/APTRepositories.js
> @@ -141,6 +141,7 @@ Ext.define('Proxmox.node.APTRepositoriesErrors', {
>  Ext.define('Proxmox.node.APTRepositoriesGrid', {
>      extend: 'Ext.grid.GridPanel',
>      xtype: 'proxmoxNodeAPTRepositoriesGrid',
> +    mixins: ['Proxmox.Mixin.CBind'],
>  
>      title: gettext('APT Repositories'),
>  
> @@ -162,6 +163,9 @@ Ext.define('Proxmox.node.APTRepositoriesGrid', {
>  	    name: 'addRepo',
>  	    disabled: true,
>  	    repoInfo: undefined,
> +	    cbind: {
> +		onlineHelp: '{onlineHelp}',
> +	    },
>  	    handler: function(button, event, record) {
>  		Proxmox.Utils.checked_command(() => {
>  		    let me = this;
> @@ -177,6 +181,7 @@ Ext.define('Proxmox.node.APTRepositoriesGrid', {
>  			url: `/api2/extjs/nodes/${panel.nodename}/apt/repositories`,
>  			method: 'PUT',
>  			extraRequestParams: extraParams,
> +			onlineHelp: me.onlineHelp,
>  			listeners: {
>  			    destroy: function() {
>  				panel.reload();
> @@ -410,6 +415,8 @@ Ext.define('Proxmox.node.APTRepositories', {
>  
>      digest: undefined,
>  
> +    onlineHelp: undefined,
> +
>      product: 'Proxmox VE', // default
>  
>      controller: {
> @@ -575,6 +582,7 @@ Ext.define('Proxmox.node.APTRepositories', {
>  	    flex: 1,
>  	    cbind: {
>  		nodename: '{nodename}',
> +		onlineHelp: '{onlineHelp}',
>  	    },
>  	    majorUpgradeAllowed: false, // TODO get release information from an API call?
>  	    listeners: {