From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: Fabian Ebner <f.ebner@proxmox.com>
Cc: pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH proxmox-widget-toolkit 1/1] node: repos: add online help
Date: Wed, 14 Jul 2021 19:41:57 +0200 [thread overview]
Message-ID: <20210714194157.25278eb3@rosa.proxmox.com> (raw)
In-Reply-To: <20210714125548.87873-1-f.ebner@proxmox.com>
Thanks for the patch!
applied both, and tried it out - works as advertised!
FWIW:
Reviewed-by: Stoiko Ivanov <s.ivanov@proxmox.com>
Tested-by: Stoiko Ivanov <s.ivanov@proxmox.com>
On Wed, 14 Jul 2021 14:55:47 +0200
Fabian Ebner <f.ebner@proxmox.com> wrote:
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> src/node/APTRepositories.js | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/src/node/APTRepositories.js b/src/node/APTRepositories.js
> index c7222fc..9b74980 100644
> --- a/src/node/APTRepositories.js
> +++ b/src/node/APTRepositories.js
> @@ -141,6 +141,7 @@ Ext.define('Proxmox.node.APTRepositoriesErrors', {
> Ext.define('Proxmox.node.APTRepositoriesGrid', {
> extend: 'Ext.grid.GridPanel',
> xtype: 'proxmoxNodeAPTRepositoriesGrid',
> + mixins: ['Proxmox.Mixin.CBind'],
>
> title: gettext('APT Repositories'),
>
> @@ -162,6 +163,9 @@ Ext.define('Proxmox.node.APTRepositoriesGrid', {
> name: 'addRepo',
> disabled: true,
> repoInfo: undefined,
> + cbind: {
> + onlineHelp: '{onlineHelp}',
> + },
> handler: function(button, event, record) {
> Proxmox.Utils.checked_command(() => {
> let me = this;
> @@ -177,6 +181,7 @@ Ext.define('Proxmox.node.APTRepositoriesGrid', {
> url: `/api2/extjs/nodes/${panel.nodename}/apt/repositories`,
> method: 'PUT',
> extraRequestParams: extraParams,
> + onlineHelp: me.onlineHelp,
> listeners: {
> destroy: function() {
> panel.reload();
> @@ -410,6 +415,8 @@ Ext.define('Proxmox.node.APTRepositories', {
>
> digest: undefined,
>
> + onlineHelp: undefined,
> +
> product: 'Proxmox VE', // default
>
> controller: {
> @@ -575,6 +582,7 @@ Ext.define('Proxmox.node.APTRepositories', {
> flex: 1,
> cbind: {
> nodename: '{nodename}',
> + onlineHelp: '{onlineHelp}',
> },
> majorUpgradeAllowed: false, // TODO get release information from an API call?
> listeners: {
next prev parent reply other threads:[~2021-07-14 17:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 12:55 Fabian Ebner
2021-07-14 12:55 ` [pmg-devel] [PATCH pmg-gui 1/1] server administration: " Fabian Ebner
2021-07-19 15:42 ` [pmg-devel] applied: " Thomas Lamprecht
2021-07-14 17:41 ` Stoiko Ivanov [this message]
2021-07-19 15:39 ` [pmg-devel] applied: [PATCH proxmox-widget-toolkit 1/1] node: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210714194157.25278eb3@rosa.proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox