public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] [PATCH pmg-api 2/2] config: freshclam: default to incremental downloads
Date: Wed, 30 Jun 2021 18:39:55 +0200	[thread overview]
Message-ID: <20210630163955.18639-3-s.ivanov@proxmox.com> (raw)
In-Reply-To: <20210630163955.18639-1-s.ivanov@proxmox.com>

clamav recently started yielding 429 (too many requests) response
codes on even comparatively low attempts to download the complete
signature files (cvd)(see [0]), instead of the incremental changes
(cdiff) (see [1] for some background)

changing the default to scriptedupdates (a.k.a. cdiff download) seems
sensible for most situations.

[0] https://docs.clamav.net/faq/faq-freshclam.html
[1] https://blog.clamav.net/2021/03/clamav-cvds-cdiffs-and-magic-behind.html

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
 src/PMG/Config.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PMG/Config.pm b/src/PMG/Config.pm
index 748ed80..20f68da 100755
--- a/src/PMG/Config.pm
+++ b/src/PMG/Config.pm
@@ -397,7 +397,7 @@ sub properties {
 	scriptedupdates => {
 	    description => "Enables ScriptedUpdates (incremental download of signatures)",
 	    type => 'boolean',
-	    default => 0
+	    default => 1
 	},
     };
 }
-- 
2.20.1





  parent reply	other threads:[~2021-06-30 16:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-30 16:39 [pmg-devel] [PATCH pmg-api 0/2] upgrade related bugfixes and improvements Stoiko Ivanov
2021-06-30 16:39 ` [pmg-devel] [PATCH pmg-api 1/2] utils: fix service_aliases usage Stoiko Ivanov
2021-06-30 16:39 ` Stoiko Ivanov [this message]
2021-07-05  6:34 ` [pmg-devel] applied-series: [PATCH pmg-api 0/2] upgrade related bugfixes and improvements Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210630163955.18639-3-s.ivanov@proxmox.com \
    --to=s.ivanov@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal